Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rgblight to RGB Matrix VPATH #13371

Merged
merged 1 commit into from Jul 2, 2021
Merged

Add rgblight to RGB Matrix VPATH #13371

merged 1 commit into from Jul 2, 2021

Conversation

fauxpark
Copy link
Member

Description

RGB Matrix requires rgblight.h for RGBLIGHT_MODE_xxx... it is now no longer implicitly visible after #13312.

@mtei would it be possible to refactor this somehow?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested review from mtei and a team June 28, 2021 18:55
drashna
drashna approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eeew, gross....

@mtei
Copy link
Contributor

mtei commented Jun 29, 2021

Hmmm...please give me some time to research.

@sigprof sigprof mentioned this pull request Jun 29, 2021
Closed
14 tasks
@mike1808
Copy link

LGTM

@drashna drashna requested a review from a team July 1, 2021 08:21
@fauxpark fauxpark merged commit b721e05 into qmk:develop Jul 2, 2021
@fauxpark fauxpark deleted the rgb-matrix-vpath-fix branch July 2, 2021 06:08
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 2, 2021
Merge remote-tracking branch 'qmk/develop' into develop
6ee255b 
* qmk/develop:
  Fix up recent checkerboards additions (qmk#13414)
  [Bug] fix Dystopia.h comma (qmk#13413)
  Add rgblight to RGB Matrix VPATH (qmk#13371)
  Cleanup gitignore (qmk#13390)
This was referenced Jul 10, 2021
Merged
Merged
@fauxpark fauxpark mentioned this pull request Jul 16, 2021
Merged
fauxpark added a commit that referenced this pull request Jul 16, 2021
@fauxpark
Revert "Add rgblight to RGB Matrix VPATH (#13371)"
c20f80a 
This reverts commit b721e05.
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
Add rgblight to RGB Matrix VPATH (qmk#13371)
529014e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@mtei mtei Awaiting requested review from mtei

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fauxpark @mtei @mike1808 @drashna