Revert "Add rgblight to RGB Matrix VPATH" #13559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b721e05.
fauxpark
force-pushed
the
revert-13371-rgb-matrix-vpath-fix
branch
from
6fd0432
to
c20f80a
Compare
drashna
approved these changes
Jul 16, 2021
% make ergodox_ez:default_glow
QMK Firmware 0.13.20
WARNING: Some git submodules are out of date or modified.
Please consider running make git-submodule.
Making ergodox_ez with keymap default_glow
avr-gcc (Homebrew AVR GCC 8.4.0_2) 8.4.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiling: keyboards/ergodox_ez/matrix.c In file included from quantum/quantum.h:45,
from keyboards/ergodox_ez/ergodox_ez.h:23,
from keyboards/ergodox_ez/matrix.c:35:
quantum/rgb_matrix/rgb_matrix.h:26:10: fatal error: rgblight_list.h: No such file or directory
#include "rgblight_list.h"
^~~~~~~~~~~~~~~~~
compilation terminated.
[ERRORS]
|
|
|
make[1]: *** [.build/obj_ergodox_ez_default_glow/matrix.o] Error 1
make: *** [ergodox_ez:default_glow] Error 1
Make finished with errors |
|
|
If so, shouldn't it be done with this PR? |
|
Yup, and done. |
mtei
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13371
With #13555 and #13509, this should theoretically not be needed anymore.