Revert "Fixed the ortho60 and ortho48 matrix layout after testing" #13456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyril279
force-pushed
the
revert-12106-nblyumberg_cannonkeys_orthofix
branch
from
8bd06df
to
b9bee79
Compare
|
@awkannan Any input? |
|
Yep! This is a good fix. |
tzarc
approved these changes
Jul 25, 2021
fauxpark
approved these changes
Jul 25, 2021
drashna
approved these changes
Jul 26, 2021
|
Thanks! |
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12106
Summary:
The ortho-fix commit breaks the 2uC layout of the ortho48 (& possibly the ortho60) by changing the matrix to associate the center/2u key to switch-position 36 (was previously 35). When the center switch is installed, position 36 is empty (no switch installed).
The commit was apparently because one user had an issue with a VIA map.
There is nothing in the PR communicating the user's actual issue, or how it translates to a correction to the matrix.
Troubleshooting/testing:
I probed my ortho48 pcb and found that the center/2u position is traced to the same pin as position 35.
Without probing the pcb, the routing of the center-switch can be determined practically by performing the column-numbers-in-the-keymap steps (outlined in the comments).
Other thoughts:
I bought this kit in June of 2020 and the matrix/Layouts for both grid and 2uC worked as expected (for me and many others). Considering the direct relationship of the matrix to the routing of the pcb, the maintainer and/or vendor should be consulted prior to such a change.
-Cyril