Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First board #13609

Merged
merged 6 commits into from Jul 22, 2021
Merged

First board #13609

merged 6 commits into from Jul 22, 2021

Conversation

h0oni
Copy link

@h0oni h0oni commented Jul 20, 2021 •
edited

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 20, 2021
drashna
drashna requested changes Jul 20, 2021
View reviewed changes
keyboards/h0oni/hotduck/config.h Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/config.h Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/config.h Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/hotduck.c Show resolved Hide resolved
keyboards/h0oni/hotduck/hotduck.h Show resolved Hide resolved
keyboards/h0oni/hotduck/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/h0oni/hotduck/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/h0oni/hotduck/keymaps/via/vial.json Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/rules.mk Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team July 20, 2021 04:57
@h0oni
Fixing issues for qmk pr
e9e8033 
Changes been made according to Drashna's comment.
@h0oni
Adding gpl license to config.h
5aab1b9
@h0oni h0oni requested review from drashna and removed request for a team July 21, 2021 00:54
fauxpark
fauxpark requested changes Jul 21, 2021
View reviewed changes
keyboards/h0oni/hotduck/config.h Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/config.h Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/config.h Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/hotduck.h Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/hotduck.c Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/keymaps/via/readme.md Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/readme.md Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/readme.md Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/rules.mk Show resolved Hide resolved
keyboards/h0oni/hotduck/rules.mk Outdated Show resolved Hide resolved
drashna
drashna requested changes Jul 21, 2021
View reviewed changes
keyboards/h0oni/hotduck/hotduck.h Outdated Show resolved Hide resolved
@h0oni
Re-arranging the layouts.
3f358e4 
Re-arranging the layouts according to the physical layout.
@h0oni h0oni requested review from drashna and fauxpark July 21, 2021 13:37
fauxpark
fauxpark requested changes Jul 22, 2021
View reviewed changes
keyboards/h0oni/hotduck/config.h Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/readme.md Outdated Show resolved Hide resolved
keyboards/h0oni/hotduck/rules.mk Outdated Show resolved Hide resolved
@h0oni
Clearing whitespaces
533201b 
fauxpark's requested changes
@h0oni h0oni requested a review from fauxpark July 22, 2021 03:23
@fauxpark fauxpark requested a review from a team July 22, 2021 03:26
@drashna
Copy link
Member

drashna commented Jul 22, 2021

Thanks!

@drashna drashna merged commit 5b8d2b5 into qmk:master Jul 22, 2021
@h0oni
Copy link
Author

h0oni commented Jul 22, 2021

Thanks! @drashna @fauxpark

This was referenced Jul 22, 2021
Merged
Merged
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 22, 2021
Merge remote-tracking branch 'qmk/develop' into develop
412e2ae 
* qmk/develop: (141 commits)
  Implement GPIO abstraction for atsam (qmk#13567)
  [Keyboard][Bug] Add timer_avr to includes for broken builds (qmk#13641)
  [Keyboard] adds new revision: dztech/dz60rgb/v2_1 (qmk#13636)
  [Keyboard] Fixing info.json for h0oni/hotduck (qmk#13640)
  [Keyboard] Ymd40v2new layouts and fixed per-switch backlight (qmk#13622)
  [Bug] Develop - DC01 left (qmk#13597)
  [Keyboard] Fix clawsome/hatchback and reviung5 compile issues (qmk#13607)
  [Keyboard] add ogurec (qmk#13242)
  [Keyboard] Add Durgod Taurus K310 keyboard (qmk#12314)
  [Keyboard] Updated keyboard & keymaps (qmk#12667)
  [Keyboard] add SPRH keyboard (qmk#12999)
  Retain brightness with lighting layers (qmk#13025)
  [Keyboard] Add keypad Satxri6key (qmk#13423)
  [Keyboard] Initial Tron Guy Labs keyboard implementation. (qmk#13438)
  [Keyboard] Add Ristretto Keyboard (qmk#13479)
  [Keyboard] New Keyboard - OBE (qmk#13545)
  [Keyboard] Add personal planck keymap (qmk#13635)
  [Keymap] narze/xd004 (qmk#13634)
  [Keyboard] Add h0oni hotduck keyboard (qmk#13609)
  Fix API generation failure caused by GRS-70EC (qmk#13631)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@h0oni @nhongooi
[Keyboard] Add h0oni hotduck keyboard (qmk#13609)
6585131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@h0oni @drashna @fauxpark