-
-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Planck Layout for floodedcodeboy #19691
Conversation
case QWERTY: | ||
if (record->event.pressed) { | ||
print("mode just switched to qwerty and this is a huge string\n"); | ||
set_single_persistent_default_layer(_QWERTY); | ||
} | ||
return false; | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire keycode is unneeded if you only have the single "default" layer.
case QWERTY: | |
if (record->event.pressed) { | |
print("mode just switched to qwerty and this is a huge string\n"); | |
set_single_persistent_default_layer(_QWERTY); | |
} | |
return false; | |
break; |
if (record->event.pressed) { | ||
rgblight_set_layer_state(1, true); | ||
} else { | ||
rgblight_set_layer_state(1, false); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could abbreviate this with:
if (record->event.pressed) { | |
rgblight_set_layer_state(1, true); | |
} else { | |
rgblight_set_layer_state(1, false); | |
} | |
rgblight_set_layer_state(1, record->event.pressed); |
However, this would be much better in the layer_state_set_user
function, as then you can use any keycode for the layers.
rgblight_set_layer_state(3, false); | ||
} | ||
break; | ||
case KC_LSFT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These would probably work better in the housekeeping_task_user()
function.
return true; | ||
} | ||
|
||
void matrix_scan_user(void) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void matrix_scan_user(void) { | |
void housekeeping_task_user(void) { |
BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite | ||
|
||
|
||
CONSOLE_ENABLE = no # Console for debug(+400) | ||
COMMAND_ENABLE = yes # Commands for debug and configuration | ||
|
||
MOUSEKEY_ENABLE = no # Mouse keys(+4700) | ||
EXTRAKEY_ENABLE = yes # Audio control and System control(+450) | ||
|
||
NKRO_ENABLE = yes # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | ||
UNICODE_ENABLE = no # Unicode | ||
|
||
AUDIO_ENABLE = yes # Audio output on port C6 | ||
MIDI_ENABLE = no # MIDI controls | ||
|
||
BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | ||
|
||
# Lighting | ||
BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality | ||
RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. | ||
|
||
RGB_MATRIX_ENABLE = no | ||
|
||
# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE | ||
SLEEP_LED_ENABLE = yes # Breathing sleep LED during USB suspend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite | |
CONSOLE_ENABLE = no # Console for debug(+400) | |
COMMAND_ENABLE = yes # Commands for debug and configuration | |
MOUSEKEY_ENABLE = no # Mouse keys(+4700) | |
EXTRAKEY_ENABLE = yes # Audio control and System control(+450) | |
NKRO_ENABLE = yes # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | |
UNICODE_ENABLE = no # Unicode | |
AUDIO_ENABLE = yes # Audio output on port C6 | |
MIDI_ENABLE = no # MIDI controls | |
BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | |
# Lighting | |
BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality | |
RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. | |
RGB_MATRIX_ENABLE = no | |
# Do not enable SLEEP_LED_ENABLE. it uses the same timer as BACKLIGHT_ENABLE | |
SLEEP_LED_ENABLE = yes # Breathing sleep LED during USB suspend | |
BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite | |
CONSOLE_ENABLE = no # Console for debug | |
COMMAND_ENABLE = yes # Commands for debug and configuration | |
MOUSEKEY_ENABLE = no # Mouse keys | |
EXTRAKEY_ENABLE = yes # Audio control and System control | |
NKRO_ENABLE = yes # Enable USB N-Key Rollover | |
UNICODE_ENABLE = no # Unicode | |
AUDIO_ENABLE = yes # Audio output | |
MIDI_ENABLE = no # MIDI controls | |
# Lighting | |
BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality | |
RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. | |
RGB_MATRIX_ENABLE = no |
Thank you for your contribution! |
Thank you for your contribution! |
Description
Create a new layout with the help of the qmk cli.
Types of Changes
Issues Fixed or Closed by This PR
Checklist