-
-
Notifications
You must be signed in to change notification settings - Fork 38.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Keychron boards - Part 1 (redo) #21406
Conversation
…-update-pt1-redo
…_firmware into kc-update-pt1-redo
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
…-update-pt1-redo
…-update-pt1-redo
…_firmware into kc-update-pt1-redo
…-update-pt1-redo
…_firmware into kc-update-pt1-redo
…-update-pt1-redo
…_firmware into kc-update-pt1-redo
…-update-pt1-redo
Since July 30th is coming up as that's the date for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since doing 1 PR to update 25 keyboards is unmanageable, doing them in batches would help make it tolerable
...IMO, this is still too big of a batch.
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
…-update-pt1-redo
…_firmware into kc-update-pt1-redo
…-update-pt1-redo
This reverts commit 1562d6b.
…-update-pt1-redo
…_firmware into kc-update-pt1-redo
…-update-pt1-redo
…-update-pt1-redo
Description
(This is a re-attempt of #21129 due to a merging mishap that I caused.
Note to self: Never sync with)master
fromgithub.com
for a PR based indevelop
.Edit: Move
#define DYNAMIC_KEYMAP_LAYER_COUNT
toinfo.json
(Original text)
This is Part 1 of a 5-part series of PRs to updating the entire Keychron lineup to current QMK standards. Since doing 1 PR to update 25 keyboards is unmanageable, doing them in batches would help make it tolerable. This
Changes:
keyboard
" level files (Ex:q2/info.json
/q2/config.h
)#define ENCODER_DEFAULT_POS 0x3
to the keyboard-levelconfig.h
inside of a#ifdef ENCODER_ENABLE
blockrules.mk
features into the keyboard levelinfo.json
rgb_matrix
driver (CKLED2001/IS31FL3733(Q1v1))bootloader
and MCUprocessor
,diode_direction
readme.md
s to include variants of boards forcompile
andflash
instructions and to provide imgur linksKeyboard-specific
keymaps
folders fromq4/ansi_v1
andq4/ansi_v2
to be underq4/ansi/keymaps
instead of these 2 variants having their ownkeymaps
folders.Basically going from this
Part 1 involves updating the following KC boards:
Types of Changes
Issues Fixed or Closed by This PR
Checklist