Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YMDK YMD62 ISO PCB #23629

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Add YMDK YMD62 ISO PCB #23629

merged 3 commits into from
Apr 30, 2024

Conversation

richdawe
Copy link
Contributor

@richdawe richdawe commented Apr 27, 2024 •
edited
Loading

Description

Port the YMDK YMD62 ISO PCB to QMK

I got my PCB from Mechboards in the UK: YMD62 at Mechboards UK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Apr 28, 2024
View reviewed changes
keyboards/ymdk/ymd62/chconf.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/config.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/halconf.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/info.json Show resolved Hide resolved
keyboards/ymdk/ymd62/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/mcuconf.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/mcuconf.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/rules.mk Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Apr 28, 2024
View reviewed changes
keyboards/ymdk/ymd62/config.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/info.json Outdated Show resolved Hide resolved
keyboards/ymdk/ymd62/info.json Outdated Show resolved Hide resolved
@richdawe richdawe changed the title Port YMDK YMD62 ISO PCB Add YMDK YMD62 ISO PCB Apr 28, 2024
@richdawe
Copy link
Contributor Author

Thanks @waffle87 and @zvecr for your help and feedback.

I've incorporated your suggested changes, and retested my YMD62 PCB and it works fine with the latest version.

I pushed two changes. I split out the qmk format-json into a separate change, otherwise it would have been hard to see all the other changes.

@richdawe richdawe requested review from zvecr and waffle87 April 29, 2024 08:30
@drashna drashna merged commit 4f08759 into qmk:master Apr 30, 2024
3 checks passed
dorianmeric added a commit to dorianmeric/qmk_firmware-dorian that referenced this pull request May 2, 2024
@dorianmeric @tzarc
@richdawe @dcpedit @flinguenheld @stephondoestech @waffle87 @dunk2k @eerraa @zvecr @lesshonor @alabahuy @stefangluszek @josh-l-wang @joe-scotto @Cipulot @drashna @rarepotato8de @key10iq @itarze @Druah @noroadsleft
update from main repo (#3)
3a4e9ec 
* Remove broken CI workflow (qmk#23631)

* Add YMDK YMD62 ISO PCB (qmk#23629)

* Masonry keyboard support (qmk#23597)

* Add Chew keyboard (qmk#23628)

* [Keyboard] Add MECHWILD BB65 (qmk#23581)

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

* [Keyboard] Add SIRIND TOMAK (qmk#23554)

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>

* [Keyboard] add jaykeeb jk65 (qmk#23536)

* [Keyboard] Fatotesa - custom asymmetric split keyboard  (qmk#23528)

Co-authored-by: jack <0x6a73@protonmail.com>

* [Keyboard] Vault35 WKL universal (qmk#23519)

* Add ScottoWing keyboard (qmk#23513)

Co-authored-by: jack <0x6a73@protonmail.com>

* Uniform ISO Enter key sequence in JIS Community Layouts (qmk#23181)

* Add EC Virgo (qmk#23173)

Co-authored-by: jack <0x6a73@protonmail.com>

* Add EC Type-B (qmk#23170)

* Add EC TKL (qmk#23177)

* Add EC660C (qmk#23171)

* Add EC Dolice (qmk#23178)

* Add EC Vero (qmk#23176)

* Add EC Menhir (qmk#23175)

* Add Chroma Support (qmk#22889)

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add EC980C (qmk#23172)

* [Keyboard] 3x3macropad (qmk#23594)

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

* [Keyboard] Add imi60 (qmk#23570)

Co-authored-by: Drashna Jaelre <drashna@live.com>

* [Keyboard] add Bruce the keyboard (qmk#23639)

* [Keyboard] Add skiller_sgk50_s4 keyboard (qmk#23636)

Co-authored-by: wb <wb@westberrytech.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

* [Keyboard] Add DK Saver Redux (qmk#23510)

* Epomaker Tide 65: Layout Data Cleanup (qmk#23643)

* [Keyboard] Add N87 (qmk#23457)

* add Bruce le Clavier (qmk#23640)

* add tkl_(ansi|iso)_wkl* community layouts (qmk#21809)

* update layouts/default/readme.md

* add tkl_wkl layouts to layouts/default

* amend layouts/default/readme.md

* `tsangan_wkl` to `wkl`

* Update readme.md

* update keymap.c

* local testing corrections applied

* add layouts/community readmes

* minor text correction(s)

* Apply suggestions from code review

* further copyright header changes

* add 60_iso_arrow and arrow_split_bs Community Layouts (qmk#22556)

---------

Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Richard Dawe <richdawe@gmail.com>
Co-authored-by: Ming-Gih Lam <dcpedit@hotmail.com>
Co-authored-by: Florent Linguenheld <f@linguenheld.fr>
Co-authored-by: Stephon Parker <sgparker62@gmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: era <73109780+eerraa@users.noreply.github.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Alabahuy <rezolutionrez@gmail.com>
Co-authored-by: Stefan Gluszek <gluszek.stefan@gmail.com>
Co-authored-by: josh-l-wang <22173775+josh-l-wang@users.noreply.github.com>
Co-authored-by: Joe Scotto <8194147+joe-scotto@users.noreply.github.com>
Co-authored-by: Cipulot <40441626+Cipulot@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Simon <68034180+rarepotato8de@users.noreply.github.com>
Co-authored-by: Ivan Gromov <38141348+key10iq@users.noreply.github.com>
Co-authored-by: Joy Lee <joylee.lc@foxmail.com>
Co-authored-by: wb <wb@westberrytech.com>
Co-authored-by: Druah <54309603+Druah@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@richdawe
Add YMDK YMD62 ISO PCB (qmk#23629)
faabfe4
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
@richdawe
Add YMDK YMD62 ISO PCB (qmk#23629)
2584d1b
mopemope pushed a commit to mopemope/qmk_firmware that referenced this pull request May 9, 2024
@richdawe @abby-ma2
Add YMDK YMD62 ISO PCB (qmk#23629)
10abfae
Coko7 pushed a commit to Coko7/qmk_firmware that referenced this pull request May 20, 2024
@richdawe @Coko7
Add YMDK YMD62 ISO PCB (qmk#23629)
3f4ad0f
aaruff pushed a commit to aaruff/qmk_firmware that referenced this pull request May 22, 2024
@richdawe @aaruff
Add YMDK YMD62 ISO PCB (qmk#23629)
a54912c
Mesabloo pushed a commit to Mesabloo/qmk_firmware that referenced this pull request May 27, 2024
@richdawe @Mesabloo
Add YMDK YMD62 ISO PCB (qmk#23629)
473842d
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@richdawe @whoisjordangarcia
Add YMDK YMD62 ISO PCB (qmk#23629)
4b96585
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@richdawe @nuphy-src
Add YMDK YMD62 ISO PCB (qmk#23629)
3e2a646
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@richdawe @AJO-Python
Add YMDK YMD62 ISO PCB (qmk#23629)
89bc54d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@waffle87 waffle87 Awaiting requested review from waffle87

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@richdawe @drashna @zvecr @keyboard-magpie @waffle87