Masonry keyboard support #23597
Merged
Masonry keyboard support #23597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
waffle87
reviewed
Apr 25, 2024
keyboards/dcpedit/masonry/config.h
Outdated
Comment on lines
6
to
8
| #define QUICK_TAP_TERM 0 | ||
| #define TAPPING_TERM 300 | ||
| #define PERMISSIVE_HOLD |
There was a problem hiding this comment.
In general, these settings should not be set at the keyboard level.
drashna
approved these changes
Apr 29, 2024
fauxpark
approved these changes
Apr 30, 2024
8 tasks
mzyt
pushed a commit
to mzyt/qmk_firmware
that referenced
this pull request
May 6, 2024
IvanJackson
pushed a commit
to IvanJackson/qmk_firmware
that referenced
this pull request
May 6, 2024
aaruff
pushed a commit
to aaruff/qmk_firmware
that referenced
this pull request
May 22, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Ardakilic
pushed a commit
to Ardakilic/qmk_firmware
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for Masonry keyboard PCB: https://github.com/dcpedit/masonry
Types of Changes
Issues Fixed or Closed by This PR
Checklist