Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error displayed in GNU sed command when execute util/new_project.sh #3923

Closed
wants to merge 4 commits into from

Conversation

leico
Copy link
Contributor

@leico leico commented Sep 16, 2018

Yesterday I encounted this issue on discord. GNU implemented sed stored this message when execute util/new_project.sh

sed: can't read : No such file or directory

It causes by different implementation of sed. Current util/new_project.sh 's sed arguments assumed BSD/Darwin. For improve above issue, this change add GNU sed command and separate each process.
Old codes are commented out. If don't need their, I will remove.

@drashna
Copy link
Member

drashna commented Oct 3, 2018

@skullydazed, didn't we have this exact issue elsewhere recently, too?

@leico
Copy link
Contributor Author

leico commented Oct 4, 2018

@drashna , @skullydazed additional information. current script is working but sed displayed those errors on Linux. I got worried this result a little. 😟
Please see my screenshot. I tried on current Linux MInt.

2018-10-04 16 10 54

@drashna
Copy link
Member

drashna commented Jan 25, 2019

I'm not sure that this is needed anymore.

However, there are a number of merge conflicts, so you may want to update and fix this.

@fauxpark fauxpark mentioned this pull request Feb 28, 2019
13 tasks
@leico
Copy link
Contributor Author

leico commented Feb 28, 2019

Fix it. Sorry to late, and #5191 looks better.

@skullydazed
Copy link
Member

Thanks for your work here, sorry we weren't able to get it merged before #5191 came along. We'll take a look at that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants