Added my personal keymap #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # keyboard/kc60/keymaps/default/compiled.hex # keyboard/kc60/keymaps/ws2812/compiled.hex
|
Yeah! It looks like you have some conflicts in your .hex files - can you revert them and recompile? |
|
Also am I reading this correctly that there are changes to the default layout? The RGB stuff isn't on everyone's KC60 and shouldn't be part of the default layout. |
|
Yeah, it looks like there are some leftovers here from #419 - if you could take care of those as well, @stanleylai, that would be awesome! |
|
The stock KC60 files were reverted earlier, so no RGB code exists there anymore. But they seemed to have been grouped together with the RGB commits anyway. Reverted from 3f6fac4 this time, should hopefully be better and clearer. |
|
Awesome - thanks! :) |
ryaninvents
pushed a commit
to ryaninvents/qmk_firmware
that referenced
this pull request
Aug 12, 2016
* Added WS2812 support for KC60 * Reorganized WS2812 support into its own keymap * Fixed relative link in README * Moved WS2812 mention in README to the bottom * Fixed titling in WS2812 README * Reverted KC60 Makefile and default keymap back * Moved RGB specific config.h to ws2812 keymap folder * Added my personal keymap * Updated compiled hex * Reverted KC60 files to 3f6fac4 before pull request qmk#419
BlueTufa
pushed a commit
to BlueTufa/qmk_firmware
that referenced
this pull request
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are sharing personal keymaps a thing? Feel free to close this pull request otherwise.