Adds keymaps for muzfuz DZ60, Planck, Clueboard66 #4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzfuz
changed the title
mechmerlin
requested changes
Jan 11, 2019
drashna
requested changes
Jan 12, 2019
|
|
||
| extern keymap_config_t keymap_config; | ||
|
|
||
| enum planck_layers |
There was a problem hiding this comment.
This is optional, and mor of a nitpick (so you can ignore).
Would you be willing to reformat this so it's conforming to the QMK Coding conventions?
|
@drashna @mechmerlin thank you for the reviews. 馃槏 I have made appropriate changes. The only one I didn't change is the formatting request in the Planck keymap, as this is in line with the default template at the moment. |
drashna
approved these changes
Jan 13, 2019
|
Thanks! |
loadedsith
added a commit
to loadedsith/qmk_firmware
that referenced
this pull request
Jan 15, 2019
* master: (759 commits) [Keyboard] Add cKeys Handwire 101 Keyboard (qmk#4848) [Keyboard] Iris via support, Rev 3 updates (qmk#4849) [Keyboard] Add bthlabs/geekpad (qmk#4840) [Keymap] Added resfury keymap (qmk#4827) Pointed LM Docs at expected keycodes (qmk#4835) Add personal userspace, update keymaps (qmk#4845) [Keyboard] Add support for THE50 (qmk#4844) Change handling of CUSTOM_MATRIX in common_features.mk slightly. Modified URLs to point to new locations [Keymap] Nyquist layout adapted from eorgodox_ez:skug (qmk#4830) [Keymap] Adds keymaps for muzfuz DZ60, Planck, Clueboard66 (qmk#4825) Changed rest note (qmk#4837) [Keymap] Add tw1t611 german keyboard layout for minidox. (qmk#4679) [Keyboard] hexon38 and Dual-role key implementation (qmk#4709) [Keymap] my keymap for the crkbd and update my iris keymap readme (qmk#4788) [Keymap] Update to personal keymaps and userspace (qmk#4831) [Keyboard] Fix layout macro name for Gergo info.json (qmk#4828) Remove empty action_function() Remove empty fn_actions[] [Keyboard] Adding support for Gergo (qmk#4792) ...
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
* Adds keymaps for muzfuz * Remove unused keys from adjust layer * Bring in line with current QMK standards.
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Adds keymaps for muzfuz * Remove unused keys from adjust layer * Bring in line with current QMK standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds keymaps for Planck, DZ60 and Clueboard66
馃憤