Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed rest term #4837

Merged
merged 2 commits into from Jan 13, 2019
Merged

Changed rest term #4837

merged 2 commits into from Jan 13, 2019

Conversation

germ
Copy link
Contributor

@germ germ commented Jan 13, 2019

Changes rest term to avoid bug as per @drashna

Types of changes

  • Core
  • Bugfix

Issues Fixed or Closed by this PR

closes #4450

Co-Authored-By: germ <jeremythegeek@gmail.com>
@germ
Copy link
Contributor Author

germ commented Jan 13, 2019

Merged requested compile directives

@drashna drashna merged commit 246c3e4 into qmk:master Jan 13, 2019
loadedsith added a commit to loadedsith/qmk_firmware that referenced this pull request Jan 15, 2019
* master: (759 commits)
  [Keyboard] Add cKeys Handwire 101 Keyboard (qmk#4848)
  [Keyboard] Iris via support, Rev 3 updates (qmk#4849)
  [Keyboard] Add bthlabs/geekpad (qmk#4840)
  [Keymap] Added resfury keymap (qmk#4827)
  Pointed LM Docs at expected keycodes (qmk#4835)
  Add personal userspace, update keymaps (qmk#4845)
  [Keyboard] Add support for THE50 (qmk#4844)
  Change handling of CUSTOM_MATRIX in common_features.mk slightly.
  Modified URLs to point to new locations
  [Keymap] Nyquist layout adapted from eorgodox_ez:skug (qmk#4830)
  [Keymap] Adds keymaps for muzfuz DZ60, Planck, Clueboard66 (qmk#4825)
  Changed rest note (qmk#4837)
  [Keymap] Add tw1t611 german keyboard layout for minidox. (qmk#4679)
  [Keyboard] hexon38 and Dual-role key implementation (qmk#4709)
  [Keymap] my keymap for the crkbd and update my iris keymap readme (qmk#4788)
  [Keymap] Update to personal keymaps and userspace (qmk#4831)
  [Keyboard] Fix layout macro name for Gergo info.json (qmk#4828)
  Remove empty action_function()
  Remove empty fn_actions[]
  [Keyboard] Adding support for Gergo (qmk#4792)
  ...
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
* Changed rest term

* Update quantum/audio/musical_notes.h

Co-Authored-By: germ <jeremythegeek@gmail.com>
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
* Changed rest term

* Update quantum/audio/musical_notes.h

Co-Authored-By: germ <jeremythegeek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All rest notes are ignored in songs, even included songs.
2 participants