Reduce CRKBD firmware size by reducing layer numbers

[drashna]

Description

Change the layer values to be sequential. This will reduce the firmware size, at it was using 16 layers, but now uses 4.

Unfortunately, the requires changing both the default keymaps, but other keymaps using the layer_state_reader code.

So this necesitate the changes of other keymaps.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[Lenbok]

Can this be merged? I tested on my new board and it's a nice boost in available space.

[drashna]

@foostan any issues with these changes?

[foostan]

Thanks! LGTM 👍

[Lenbok]

Question: I just converted my keymaps to userspace (in Lenbok@74e7e5a), so now _RAISE, _LOWER and _ADJUST are defined in my users/lenbok/lenbok.h. When I I test this PR (regardless of whether I update the #defines in my lenbok.h to correspond with the new layer indices in this PR) now I get:

Compiling: keyboards/crkbd/lib/layer_state_reader.c                                                keyboards/crkbd/lib/layer_state_reader.c: In function ‘read_layer_state’:
keyboards/crkbd/lib/layer_state_reader.c:8:21: error: ‘_RAISE’ undeclared (first use in this function)
 #define L_RAISE (1<<_RAISE)
                     ^
keyboards/crkbd/lib/layer_state_reader.c:20:8: note: in expansion of macro ‘L_RAISE’
   case L_RAISE:
        ^
keyboards/crkbd/lib/layer_state_reader.c:8:21: note: each undeclared identifier is reported only once for each function it appears in
 #define L_RAISE (1<<_RAISE)
                     ^
keyboards/crkbd/lib/layer_state_reader.c:20:8: note: in expansion of macro ‘L_RAISE’
   case L_RAISE:
        ^
keyboards/crkbd/lib/layer_state_reader.c:7:21: error: ‘_LOWER’ undeclared (first use in this function)
 #define L_LOWER (1<<_LOWER)
                     ^
keyboards/crkbd/lib/layer_state_reader.c:23:8: note: in expansion of macro ‘L_LOWER’
   case L_LOWER:
        ^
keyboards/crkbd/lib/layer_state_reader.c:9:22: error: ‘_ADJUST’ undeclared (first use in this function)
 #define L_ADJUST (1<<_ADJUST)
                      ^
keyboards/crkbd/lib/layer_state_reader.c:26:8: note: in expansion of macro ‘L_ADJUST’
   case L_ADJUST:
        ^
 [ERRORS]
 |
 |
 |
tmk_core/rules.mk:369: recipe for target '.build/obj_crkbd_rev1_lenbok/./lib/layer_state_reader.o' failed

Is there something I need to do so that layer_state_reader.c gets my userspace defines?

[drashna]

Ah, yes, this is bugged. :(

[drashna]

@Lenbok I reverted the change, so the code uses hard coded values. That should fix it for now.

However, the proper fix is to move as much of the OLED code into the keymap.c file (or into the folder).

There are some other possible solutions here, but I think the keymap is the best option, long term. However, this PR's goal isn't to fix that. Right now, it's to reduce the compiled size, to avoid feature creep, and unintentional bloat.
I'll open another PR that brings the Corne Keyboard more in line with the Helix code, if that's okay with @foostan.

[foostan]

Sorry for the late reply.

I'll open another PR that brings the Corne Keyboard more in line with the Helix code, if that's okay with @foostan.

Sounds good for me. Thanks!

[mechmerlin]

looks good, thanks!