-
-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change split_common to use RGBLIGHT_SPLIT #5509
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
aebddfc
add temporary pdhelix(Patched Helix) code
mtei c01656a
add I2C_slave_buffer_t to quantum/split_common/transport.c
mtei d35069f
temporary cherry-pick from #5020
mtei f6e8aeb
add post_config.h support to build_keyboard.mk
mtei 1aa14c5
add quantum/rgblight_post_config.h, quantum/split_common/post_config.h
mtei 57e124c
Change split_common's transport.c I2C to use the synchronization feat…
mtei 07c33fc
Change split_common's transport.c serial to use the synchronization f…
mtei 80118a6
test RGBLIGHT_SPLIT on keyboards/handwired/pdhelix
mtei dbbdfa3
Test End Revert "test RGBLIGHT_SPLIT on keyboards/handwired/pdhelix"
mtei 4d7310f
Test End, Revert "temporary cherry-pick from #5020"
mtei c8d1c83
Test End, Revert "add temporary pdhelix(Patched Helix) code"
mtei 647c0a9
temporarily cherry-pick from #5020 to see if it passes the travis-ci …
mtei 6b77e60
Passed the travis-ci test. Revert "temporarily cherry-pick from #5020…
mtei 35d6855
update docs/config_options.md
mtei c68ee60
update split_common/transport.c, improves maintainability of serial t…
mtei a3f7089
Merge branch 'master' into split_common-use-RGBLIGHT_SPLIT
mtei be48ca1
temporary cherry-pick from #5020
mtei 89ad6eb
fix build fail keebio/iris/rev3:default
mtei 21b43bc
fix build fail lets_split_eh/eh:default
mtei 419f045
Revert "temporary cherry-pick from #5020"
mtei 978d26a
temporary cherry-pick from #5020 (0.6.336)
mtei 4c56c82
Revert "temporary cherry-pick from #5020 (0.6.336)"
mtei e5f59ad
Merge branch 'master' into split_common-use-RGBLIGHT_SPLIT
mtei fa28d10
temporary cherry-pick from #5020 (0.6.336)
mtei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required to work properly?
Eg, can the post_config stuff be moved so this isn't needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary.
It is necessary to prevent unnecessary dependencies between header files between modules in lower layers.
For example, quantum/split_common/transport.c needs to define SERIAL_USE_MULTI_TRANSACTION of serial when using RGBLIGHT_SPLIT.
It is not good to solve this with serial.h and rgblight.h.