Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor budget96 to remove custom i2c code in favor of QMK i2c_master #5571

Merged
merged 3 commits into from
Apr 7, 2019
Merged

Refactor budget96 to remove custom i2c code in favor of QMK i2c_master #5571

merged 3 commits into from
Apr 7, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Apr 7, 2019 •
edited
Loading

Description

Removed custom i2c code in favor of QMK's i2c_master. In addition fixed up the readme.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna merged commit a8e3462 into qmk:master Apr 7, 2019
@drashna
Copy link
Member

drashna commented Apr 7, 2019

Thanks!

@mechmerlin mechmerlin deleted the feature/budget96_refactor branch April 17, 2019 03:47
danielo515 pushed a commit to danielo515/qmk_firmware that referenced this pull request May 15, 2019
@mechmerlin @danielo515
[Keyboard] Refactor budget96 to remove custom i2c code in favor of QM…
c1a74d0 
…K i2c_master (qmk#5571)

* remove custom i2c code in favor of QMK i2c_master

* fix readme

* disable bootmagic as it doesn't work on bmc boards
shimesaba-type0 pushed a commit to shimesaba-type0/qmk_firmware that referenced this pull request Jun 22, 2019
@mechmerlin @shimesaba-type0
[Keyboard] Refactor budget96 to remove custom i2c code in favor of QM…
17eb602 
…K i2c_master (qmk#5571)

* remove custom i2c code in favor of QMK i2c_master

* fix readme

* disable bootmagic as it doesn't work on bmc boards
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@mechmerlin @Timbus
[Keyboard] Refactor budget96 to remove custom i2c code in favor of QM…
313cb9b 
…K i2c_master (qmk#5571)

* remove custom i2c code in favor of QMK i2c_master

* fix readme

* disable bootmagic as it doesn't work on bmc boards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keyboard optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mechmerlin @drashna