[Keyboard] Add keyboard Naked60 #6527

Salicylic-acid3 · 2019-08-12T17:18:18Z

Description

Types of Changes

Add Naekd60 keyboard.

A 60 keys Ortholinear keyboard.
Salicylic-acid3

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/naked60/keymaps/default/keymap.c

drashna

Is there a specific reason for the custom split implementation, over using the Split Keyboard feature?

https://docs.qmk.fm/#/feature_split_keyboard

keyboards/naked60/readme.md

Salicylic-acid3 · 2019-10-07T13:13:57Z

It looks like it ’s taking a while, was there a problem with this pull request?

noroadsleft · 2019-10-07T20:18:32Z

@Salicylic-acid3 I can't speak for the rest of the team, but personally, my knowledge about QMK is fairly narrow. I don't have any experience with split keyboard code, and very little with custom matrix, so probably at minimum, 80% of your changes here are above my head.

Also, these large pull requests (you've got 43 files and over 4,000 lines here) take a long time to review, even for someone who knows the code.

noroadsleft

Your info.json file is also invalid, but it'll be easier for me to fix it after this is merged than it would be for me to walk you through fixing it.

keyboards/naked60/keymaps/default/keymap.c

keyboards/naked60/rules.mk

yanfali · 2019-10-07T20:36:16Z

It looks like it ’s taking a while, was there a problem with this pull request?

Yeah, super large PR for a new keyboard. Next time perhaps break up into logical units. Like all the keymaps could have gone into their own PR after the base keyboard was submitted. Usually a keyboard is about 10 files. The longer you make a PR the less likely it is someone will have the appetite to review it. We are volunteers and we will make human decisions based around throughput. Sorry.

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Changed the alias.

Unnecessary part was deleted and explanation was added to the boot loader.

keyboards/naked60/rev1/rev1.h

keyboards/naked60/rev1/rev1.c

keyboards/naked60/rev1/config.h

keyboards/naked60/keymaps/salicylic/rules.mk

keyboards/naked60/keymaps/salicylic_with_nafuda/rules.mk

keyboards/naked60/keymaps/salicylic_with_setta21/rules.mk

keyboards/naked60/rules.mk

Co-Authored-By: fauxpark <fauxpark@gmail.com>

fauxpark · 2019-10-08T14:41:47Z

Please also make sure the keymap READMEs render correctly in GitHub. :)

Cleaned up declarations in rules.mk.

Changed remaining aliases.

Cleaned up declarations in rev1.c.

The appearance has been adjusted.

noroadsleft

A lot of small related changes here.

keyboards/naked60/keymaps/default/readme.md

keyboards/naked60/keymaps/default_with_nafuda/readme.md

keyboards/naked60/keymaps/default_with_setta21/readme.md

keyboards/naked60/keymaps/salicylic/readme.md

keyboards/naked60/keymaps/salicylic/rules.mk

keyboards/naked60/keymaps/salicylic_with_nafuda/rules.mk

keyboards/naked60/keymaps/salicylic_with_setta21/rules.mk

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

The appearance has been adjusted. Unnecessary rules.mk was deleted.

noroadsleft

Looks good to me.

keyboards/naked60/keymaps/default/readme.md

keyboards/naked60/readme.md

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Changed to markdown format.

…are-1

fauxpark

Just a couple small tweaks to make the backslash render properly, then I think this is good to go 👍

keyboards/naked60/keymaps/default/readme.md

keyboards/naked60/keymaps/salicylic/readme.md

Co-Authored-By: fauxpark <fauxpark@gmail.com>

drashna

Thanks!

* Add Naked60 * readme Update * Update keyboards/naked60/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Updated keymaps Changed the alias. * updated rule.mk Unnecessary part was deleted and explanation was added to the boot loader. * Update keyboards/naked60/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/naked60/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/naked60/rev1/rev1.h Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/naked60/rev1/rev1.h Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/naked60/rev1/config.h Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/naked60/rev1/config.h Co-Authored-By: fauxpark <fauxpark@gmail.com> * Updated keymaps rules.mk. Cleaned up declarations in rules.mk. * Updated keymap Changed remaining aliases. * Update rev1.c Cleaned up declarations in rev1.c. * Update readme The appearance has been adjusted. * Update keyboards/naked60/keymaps/default/readme.md Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/default_with_nafuda/readme.md Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/default_with_nafuda/readme.md Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/salicylic/readme.md Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/salicylic/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/salicylic_with_nafuda/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/salicylic_with_nafuda/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/salicylic_with_setta21/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/salicylic_with_setta21/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/rev1/rev1.c Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/default_with_nafuda/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/salicylic/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/default_with_nafuda/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/default_with_setta21/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/naked60/keymaps/default_with_setta21/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Updated keymaps The appearance has been adjusted. Unnecessary rules.mk was deleted. * Update keyboards/naked60/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update readme Changed to markdown format. * Update keyboards/naked60/keymaps/default/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/naked60/keymaps/salicylic/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/naked60/keymaps/salicylic/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com>

Add Naked60

8034c4a

mechmerlin added the keyboard label Aug 13, 2019

drashna reviewed Aug 14, 2019

View reviewed changes

keyboards/naked60/keymaps/default/keymap.c Outdated Show resolved Hide resolved

drashna requested changes Aug 14, 2019

View reviewed changes

keyboards/naked60/readme.md Outdated Show resolved Hide resolved

readme Update

f000ccd

Salicylic-acid3 requested a review from drashna September 16, 2019 15:54

drashna approved these changes Sep 19, 2019

View reviewed changes

drashna requested review from a team and drashna September 19, 2019 00:47

Merge remote-tracking branch 'root_branch/master'

7d3a370

noroadsleft requested changes Oct 7, 2019

View reviewed changes

Salicylic-acid3 and others added 3 commits October 8, 2019 22:03

Update keyboards/naked60/rules.mk

995a854

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Updated keymaps

9895f5e

Changed the alias.

updated rule.mk

4bbd0ea

Unnecessary part was deleted and explanation was added to the boot loader.

fauxpark requested changes Oct 8, 2019

View reviewed changes

Salicylic-acid3 and others added 6 commits October 8, 2019 23:21

Update keyboards/naked60/rules.mk

de7db99

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/naked60/rules.mk

b772727

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/naked60/rev1/rev1.h

296c9e5

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/naked60/rev1/rev1.h

a0eebe6

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/naked60/rev1/config.h

de2791f

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/naked60/rev1/config.h

4cc2af8

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Salicylic-acid3 added 4 commits October 9, 2019 00:03

Updated keymaps rules.mk.

e9bdfed

Cleaned up declarations in rules.mk.

Updated keymap

df6b855

Changed remaining aliases.

Update rev1.c

4b76f18

Cleaned up declarations in rev1.c.

Update readme

44189f2

The appearance has been adjusted.

noroadsleft requested changes Oct 8, 2019

View reviewed changes

Salicylic-acid3 and others added 11 commits October 9, 2019 01:56

Update keyboards/naked60/keymaps/salicylic_with_setta21/rules.mk

39dd99f

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/naked60/keymaps/salicylic_with_setta21/rules.mk

37d97f8

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/naked60/rev1/rev1.c

cda0a0e

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/naked60/rules.mk

bdb0700

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/naked60/rules.mk

08eba9b

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/naked60/keymaps/default_with_nafuda/rules.mk

b6ab726

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/naked60/keymaps/salicylic/rules.mk

72421a0

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/naked60/keymaps/default_with_nafuda/rules.mk

f1124f1

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/naked60/keymaps/default_with_setta21/rules.mk

18e90f8

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/naked60/keymaps/default_with_setta21/rules.mk

05c3202

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

Updated keymaps

bfc6cb1

The appearance has been adjusted. Unnecessary rules.mk was deleted.

noroadsleft approved these changes Oct 8, 2019

View reviewed changes

fauxpark reviewed Oct 8, 2019

View reviewed changes

keyboards/naked60/keymaps/default/readme.md Outdated Show resolved Hide resolved

fauxpark reviewed Oct 8, 2019

View reviewed changes

keyboards/naked60/readme.md Outdated Show resolved Hide resolved

Salicylic-acid3 and others added 3 commits October 9, 2019 23:21

Update keyboards/naked60/readme.md

c0bc2d0

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update readme

d9c9331

Changed to markdown format.

Merge branch 'master' of https://github.com/Salicylic-acid3/qmk_firmw…

ce25d41

…are-1

noroadsleft requested a review from fauxpark October 9, 2019 17:25

fauxpark requested changes Oct 9, 2019

View reviewed changes

keyboards/naked60/keymaps/default/readme.md Outdated Show resolved Hide resolved

keyboards/naked60/keymaps/salicylic/readme.md Outdated Show resolved Hide resolved

keyboards/naked60/keymaps/salicylic/readme.md Outdated Show resolved Hide resolved

Salicylic-acid3 and others added 3 commits October 10, 2019 07:31

Update keyboards/naked60/keymaps/default/readme.md

8bc3268

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/naked60/keymaps/salicylic/readme.md

78ec556

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Update keyboards/naked60/keymaps/salicylic/readme.md

b65f4c6

Co-Authored-By: fauxpark <fauxpark@gmail.com>

fauxpark approved these changes Oct 9, 2019

View reviewed changes

drashna approved these changes Oct 16, 2019

View reviewed changes

drashna merged commit f360c27 into qmk:master Oct 16, 2019

noroadsleft mentioned this pull request Oct 21, 2019

Naked60 Configurator bugfix #7108

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keyboard] Add keyboard Naked60 #6527

[Keyboard] Add keyboard Naked60 #6527

Salicylic-acid3 commented Aug 12, 2019

drashna left a comment

Salicylic-acid3 commented Oct 7, 2019

noroadsleft commented Oct 7, 2019

noroadsleft left a comment

yanfali commented Oct 7, 2019

fauxpark commented Oct 8, 2019

noroadsleft left a comment

noroadsleft left a comment

fauxpark left a comment

drashna left a comment

[Keyboard] Add keyboard Naked60 #6527

[Keyboard] Add keyboard Naked60 #6527

Conversation

Salicylic-acid3 commented Aug 12, 2019

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

drashna left a comment

Choose a reason for hiding this comment

Salicylic-acid3 commented Oct 7, 2019

noroadsleft commented Oct 7, 2019

noroadsleft left a comment

Choose a reason for hiding this comment

yanfali commented Oct 7, 2019

fauxpark commented Oct 8, 2019

noroadsleft left a comment

Choose a reason for hiding this comment

noroadsleft left a comment

Choose a reason for hiding this comment

fauxpark left a comment

Choose a reason for hiding this comment

drashna left a comment

Choose a reason for hiding this comment