Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KEYMAP_SECTION_ENABLE #7882

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Conversation

fauxpark
Copy link
Member

Description

This rule and associated linker scripts appear to have been for the TMK keymap editor. From what I can tell, it places the keymap at a fixed address so you can edit the hex after compilation. Since we don't support it, and already have things like the Configurator and VIA, it's not really needed.

I also removed some related things from the Ergodone rules.mk, which weren't used anywhere.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 13, 2020 17:27
@drashna drashna requested a review from a team January 13, 2020 18:03
@fauxpark fauxpark merged commit 1e670f5 into qmk:master Jan 16, 2020
@fauxpark fauxpark deleted the keymap-section-disable branch January 16, 2020 13:32
brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request Jan 17, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 12, 2020
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 14, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 26, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants