Changing board names to prevent confusion #8412

blindassassin111 · 2020-03-14T01:14:08Z

Description

Changed names of 3 boards I designed to remove the reference to a name that will cause confusion in the future as I want to have a product use that name but given the conflict, I decided to rename these to PCB_BH to help with possible confusion.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Changing name to prevent confusion.

Changing Name to prevent confusion.

Changing name to prevent confusion.

Changing Name to prevent confusion

Changing name to prevent confusion

Changing the board names to prevent confusion for a future project I will have merged. ie. A naming conflict.

Forgot 2 files, ranamed

keyboards/omnikey_bh/readme.md

keyboards/z150_bh/readme.md

noroadsleft · 2020-03-14T19:17:23Z

I've labeled this breaking_change as this changes the firmware build instructions for anyone who already has one of these PCBs. This change needs to be conveyed to the already-established end users.

skullydazed · 2020-03-14T21:23:37Z

Since you're changing these anyway, and you have at least one more PCB on the way, would it make sense to group these under one directory? One of our long term goals is to get everything organized as keyboards/<manufacturer>/<keyboard_name> and this would save us some work later. :)

blindassassin111 · 2020-03-14T23:54:16Z

Since you're changing these anyway, and you have at least one more PCB on the way, would it make sense to group these under one directory? One of our long term goals is to get everything organized as keyboards/<manufacturer>/<keyboard_name> and this would save us some work later. :)

I don't think it would make sense for this specific scenario, as I don't plan on doing another pcb like this I just regret erroneously adding the blackheart name to the end of the pcbs as I want to use that name for an actual project rather than tagging it on these just because I didn't want to just label them what the original manus did.

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

blindassassin111 · 2020-04-05T19:31:00Z

Is there anything I need to do in order to get this pushed through? I made the changes requested yet nothing so unsure of where to go from here.

keyboards/at101_bh/at101_bh.h

keyboards/omnikey_bh/omnikey_bh.h

Co-Authored-By: Ryan <fauxpark@gmail.com>

noroadsleft

Both the following lines need to be deleted.

qmk_firmware/keyboards/at101_bh/at101_bh.h

Line 27 in 73fd6fc

#endif

qmk_firmware/keyboards/omnikey_bh/omnikey_bh.h

Line 21 in 73fd6fc

#endif

noroadsleft · 2020-04-29T18:17:10Z

I've retargeted this to the future branch so as to use that workflow to put a changelog entry on this, but I may revisit that decision in the next couple of days.

noroadsleft · 2020-05-02T18:26:27Z

Going to go ahead and merge this to the future branch. This Breaking Changes cycle has a couple of similar PRs in it, and I'll write a changelog for all of them together.

Thanks!

* Changing Name Changing name to prevent confusion. * Changing Name Changing Name to prevent confusion. * Changing Name Changing name to prevent confusion. * Changing Name Changing Name to prevent confusion * Changing Name Changing name to prevent confusion * Changing board names Changing the board names to prevent confusion for a future project I will have merged. ie. A naming conflict. * Changed Name again Forgot 2 files, ranamed * Update keyboards/z150_bh/readme.md * Update keyboards/omnikey_bh/readme.md * Update keyboards/at101_bh/at101_bh.h * Update keyboards/omnikey_bh/omnikey_bh.h * Update at101_bh.h * Update omnikey_bh.h

* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (#8968) * Convert V-USB usbdrv to a submodule (#8321) * Unify Tap Hold functions and documentation (#8348) * Changing board names to prevent confusion (#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (#8499) * Move spaceman keyboards (#8830) * Migrate miscellaneous `fn_actions` entries (#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (#8537) * Refactor Lily58 to use split_common (#6260) * Refactor zinc to use split_common (#7114) * Add a message if bin/qmk doesn't work (#9000) * Fix conflicting types for 'tfp_printf' (#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (#6480) * Refactor and updates to TKC1800 code (#8472) * Switch to qmk forks for everything (#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (#8484) * Audio enable corrections (2/3) (#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (#8582) * Audio enable corrections (Part 4) (#8974) * Fix typo from PR7114 (#9171) * Augment future branch Changelogs (#8978) * Revert "Branch point for 2020 May 30 Breaking Change"

* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (qmk#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (qmk#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (qmk#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (qmk#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (qmk#8968) * Convert V-USB usbdrv to a submodule (qmk#8321) * Unify Tap Hold functions and documentation (qmk#8348) * Changing board names to prevent confusion (qmk#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (qmk#8499) * Move spaceman keyboards (qmk#8830) * Migrate miscellaneous `fn_actions` entries (qmk#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (qmk#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (qmk#8537) * Refactor Lily58 to use split_common (qmk#6260) * Refactor zinc to use split_common (qmk#7114) * Add a message if bin/qmk doesn't work (qmk#9000) * Fix conflicting types for 'tfp_printf' (qmk#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (qmk#6480) * Refactor and updates to TKC1800 code (qmk#8472) * Switch to qmk forks for everything (qmk#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (qmk#8484) * Audio enable corrections (2/3) (qmk#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (qmk#8582) * Audio enable corrections (Part 4) (qmk#8974) * Fix typo from PR7114 (qmk#9171) * Augment future branch Changelogs (qmk#8978) * Revert "Branch point for 2020 May 30 Breaking Change"

blindassassin111 added 7 commits March 13, 2020 19:16

Changing Name

2d7e0e4

Changing name to prevent confusion.

Changing Name

636d13b

Changing Name to prevent confusion.

Changing Name

e550c2b

Changing name to prevent confusion.

Changing Name

9298d1e

Changing Name to prevent confusion

Changing Name

c489bba

Changing name to prevent confusion

Changing board names

f8d4b36

Changing the board names to prevent confusion for a future project I will have merged. ie. A naming conflict.

Changed Name again

ecfcf9e

Forgot 2 files, ranamed

noroadsleft requested changes Mar 14, 2020

View reviewed changes

keyboards/omnikey_bh/readme.md Outdated Show resolved Hide resolved

keyboards/z150_bh/readme.md Outdated Show resolved Hide resolved

noroadsleft added breaking_change Changes that need to wait for a version increment keyboard labels Mar 14, 2020

noroadsleft requested a review from a team March 14, 2020 19:16

blindassassin111 and others added 2 commits March 14, 2020 18:54

Update keyboards/z150_bh/readme.md

a4be34b

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

Update keyboards/omnikey_bh/readme.md

f58d72b

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

drashna approved these changes Mar 16, 2020

View reviewed changes

blindassassin111 requested a review from noroadsleft March 20, 2020 20:08

Erovia approved these changes Apr 8, 2020

View reviewed changes

drashna requested a review from a team April 12, 2020 16:54

fauxpark requested changes Apr 12, 2020

View reviewed changes

keyboards/at101_bh/at101_bh.h Outdated Show resolved Hide resolved

keyboards/omnikey_bh/omnikey_bh.h Outdated Show resolved Hide resolved

blindassassin111 and others added 2 commits April 13, 2020 11:06

Update keyboards/at101_bh/at101_bh.h

e9a09a5

Co-Authored-By: Ryan <fauxpark@gmail.com>

Update keyboards/omnikey_bh/omnikey_bh.h

73fd6fc

Co-Authored-By: Ryan <fauxpark@gmail.com>

noroadsleft requested changes Apr 13, 2020

View reviewed changes

blindassassin111 added 2 commits April 14, 2020 14:40

Update at101_bh.h

0f1b021

Update omnikey_bh.h

76474ae

noroadsleft approved these changes Apr 29, 2020

View reviewed changes

noroadsleft added the future_2020q2 label Apr 29, 2020

noroadsleft changed the base branch from master to future April 29, 2020 18:16

noroadsleft merged commit 077807e into qmk:future May 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changing board names to prevent confusion #8412

Changing board names to prevent confusion #8412

blindassassin111 commented Mar 14, 2020

noroadsleft commented Mar 14, 2020

skullydazed commented Mar 14, 2020

blindassassin111 commented Mar 14, 2020

blindassassin111 commented Apr 5, 2020

noroadsleft left a comment

noroadsleft commented Apr 29, 2020

noroadsleft commented May 2, 2020 •

edited

Changing board names to prevent confusion #8412

Changing board names to prevent confusion #8412

Conversation

blindassassin111 commented Mar 14, 2020

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

noroadsleft commented Mar 14, 2020

skullydazed commented Mar 14, 2020

blindassassin111 commented Mar 14, 2020

blindassassin111 commented Apr 5, 2020

noroadsleft left a comment

Choose a reason for hiding this comment

noroadsleft commented Apr 29, 2020

noroadsleft commented May 2, 2020 • edited

noroadsleft commented May 2, 2020 •

edited