Audio enable corrections (2/3) #8903

JohSchneider · 2020-04-24T16:11:58Z

fixing wrong configuration of AUDIO feature

Description

audio_avr.c does not default to any pin, there has to be a #define XX_AUDIO in config.h at some level, for it
to actually work
otherwise the audio-code ends up cluttering the firmware, possibly breaking builds because the maximum allowed
firmware size is exceeded

=> these changes want to fix this by disabling audio on keyboards that have audio mis-configured = non-functional

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr

Changes should be aligned with #8901, however it might be worth waiting till its merged.

keyboards/ckeys/handwire_101/rules.mk

keyboards/clueboard/card/keymaps/default/rules.mk

keyboards/eco/rules.mk

keyboards/navi10/rev3/rules.mk

keyboards/preonic/rev1/rules.mk

keyboards/preonic/rev2/rules.mk

keyboards/scarletbandana/rules.mk

keyboards/sck/neiso/rules.mk

keyboards/subatomic/rules.mk

keyboards/vision_division/keymaps/default/rules.mk

keyboards/vision_division/rules.mk

the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size

JohSchneider · 2020-05-07T00:46:27Z

git rebase origin/future; git push --force; echo "done :-)"

keyboards/vision_division/keymaps/default/rules.mk

docs/ChangeLog/20200530/PR8903.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

since it now would change nothing compared to the keyboards base rule.mk

noroadsleft · 2020-05-10T01:03:46Z

Thanks!

* audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: add Changelog entry * audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: align comment changes with #8901 * audio-configuration: changelow wording * audio-configuration: remove rules.mk since it now would change nothing compared to the keyboards base rule.mk

* audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: add Changelog entry * audio-configuration: fix avr boards with wrong configuration the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size * audio-configuration: align comment changes with qmk#8901 * audio-configuration: changelow wording * audio-configuration: remove rules.mk since it now would change nothing compared to the keyboards base rule.mk

* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (#8968) * Convert V-USB usbdrv to a submodule (#8321) * Unify Tap Hold functions and documentation (#8348) * Changing board names to prevent confusion (#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (#8499) * Move spaceman keyboards (#8830) * Migrate miscellaneous `fn_actions` entries (#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (#8537) * Refactor Lily58 to use split_common (#6260) * Refactor zinc to use split_common (#7114) * Add a message if bin/qmk doesn't work (#9000) * Fix conflicting types for 'tfp_printf' (#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (#6480) * Refactor and updates to TKC1800 code (#8472) * Switch to qmk forks for everything (#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (#8484) * Audio enable corrections (2/3) (#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (#8582) * Audio enable corrections (Part 4) (#8974) * Fix typo from PR7114 (#9171) * Augment future branch Changelogs (#8978) * Revert "Branch point for 2020 May 30 Breaking Change"

* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (qmk#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (qmk#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (qmk#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (qmk#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (qmk#8968) * Convert V-USB usbdrv to a submodule (qmk#8321) * Unify Tap Hold functions and documentation (qmk#8348) * Changing board names to prevent confusion (qmk#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (qmk#8499) * Move spaceman keyboards (qmk#8830) * Migrate miscellaneous `fn_actions` entries (qmk#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (qmk#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (qmk#8537) * Refactor Lily58 to use split_common (qmk#6260) * Refactor zinc to use split_common (qmk#7114) * Add a message if bin/qmk doesn't work (qmk#9000) * Fix conflicting types for 'tfp_printf' (qmk#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (qmk#6480) * Refactor and updates to TKC1800 code (qmk#8472) * Switch to qmk forks for everything (qmk#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (qmk#8484) * Audio enable corrections (2/3) (qmk#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (qmk#8582) * Audio enable corrections (Part 4) (qmk#8974) * Fix typo from PR7114 (qmk#9171) * Augment future branch Changelogs (qmk#8978) * Revert "Branch point for 2020 May 30 Breaking Change"

JohSchneider changed the title ~~Audio enable corrections 2~~ Audio enable corrections (2/3) Apr 24, 2020

JohSchneider force-pushed the audio_enable_corrections_2 branch from 667c57c to 13be79f Compare April 24, 2020 16:16

JohSchneider mentioned this pull request Apr 24, 2020

Audio_Enable, AVR template update #8901

Merged

13 tasks

noroadsleft force-pushed the future branch from e42e791 to 4445fc5 Compare April 24, 2020 18:54

drashna approved these changes Apr 29, 2020

View reviewed changes

drashna requested review from noroadsleft and a team April 29, 2020 05:52

drashna added the keyboard label Apr 29, 2020

noroadsleft force-pushed the future branch from 4445fc5 to 43fa4c2 Compare April 29, 2020 17:02

JohSchneider mentioned this pull request Apr 30, 2020

Audio enable corrections (Part 4) #8974

Merged

13 tasks

zvecr requested changes May 1, 2020

View reviewed changes