Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio enable corrections (2/3) #8903

Merged
merged 6 commits into from
May 10, 2020
Merged

Audio enable corrections (2/3) #8903

merged 6 commits into from
May 10, 2020

Commits on May 7, 2020

  1. audio-configuration: fix avr boards with wrong configuration 

    the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size
    Johannes committed May 7, 2020
    Configuration menu
    Copy the full SHA
    f7d6a03 View commit details
    Browse the repository at this point in the history

  2. audio-configuration: add Changelog entry

    Johannes committed May 7, 2020
    Configuration menu
    Copy the full SHA
    ced4a64 View commit details
    Browse the repository at this point in the history

  3. audio-configuration: fix avr boards with wrong configuration 

    the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size
    Johannes committed May 7, 2020
    Configuration menu
    Copy the full SHA
    8b3b406 View commit details
    Browse the repository at this point in the history

  4. audio-configuration: align comment changes with qmk#8901

    @JohSchneider
    JohSchneider authored and Johannes committed May 7, 2020
    Configuration menu
    Copy the full SHA
    d1182f5 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. audio-configuration: changelow wording 

    Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
    @JohSchneider @noroadsleft
    JohSchneider and noroadsleft committed May 8, 2020
    Configuration menu
    Copy the full SHA
    53cbce9 View commit details
    Browse the repository at this point in the history

  2. audio-configuration: remove rules.mk 

    since it now would change nothing compared to the keyboards base rule.mk
    @JohSchneider
    JohSchneider committed May 8, 2020
    Configuration menu
    Copy the full SHA
    c792044 View commit details
    Browse the repository at this point in the history