Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix crash when a HID device has no input reports #205

Merged
merged 1 commit into from
Jul 17, 2020
Merged

[Windows] Fix crash when a HID device has no input reports #205

merged 1 commit into from
Jul 17, 2020

Commits on Jul 16, 2020

  1. [Windows] Fix crash when a HID device has no input reports 

    Some devices, like the XD002 keyboard with the factory firmware, have
HID report descriptors which do not declare any input reports.  If such
HID descriptor additionally had the vendor-defined page and usage codes
which correspond to the HID console, QMK Toolbox tried to use that HID
interface as a HID console, and an attempt to read the nonexistent input
report caused a crash inside HidLibrary; this made using QMK Toolbox
impossible when a device with such HID report descriptor is connected.

Add a check for a non-zero input report size to GetListableDevices() to
prevent the attempt to use a HID interface without any input repors as a
HID console.
    @sigprof
    sigprof committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    365efe9 View commit details
    Browse the repository at this point in the history