Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tally source Connected state #16

Closed
SpComb opened this issue Jan 2, 2017 · 0 comments
Closed

Tally source Connected state #16

SpComb opened this issue Jan 2, 2017 · 0 comments
Labels
bug

Comments

@SpComb
Copy link
Member

SpComb commented Jan 2, 2017

I suspect the tally:SourceState.Connected state is set incorrectly, and will always be true: https://github.com/qmsk/e2/blob/v0.4.1/tally/state.go#L131

I assume that the tally:Source.xmlClient will never be nil in the current implementation.

The same applies to the Source.updateState: https://github.com/qmsk/e2/blob/master/tally/source.go#L87

These should either use the closed, err state set by tally:Source.run, or that func should also set xmlClient to nil.
@SpComb SpComb added the bug label Jan 2, 2017
@SpComb SpComb mentioned this issue Jan 2, 2017
Closed
depili added a commit to depili/e2 that referenced this issue Jan 5, 2017
@depili
Fix issues qmsk#16 & qmsk#17
733c263 
We now use the source.closed & source.err states to determine source.Connected
@SpComb SpComb closed this as completed in 854c888 Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SpComb