Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qx.ui.toolbar.Toolbar.removeAll() doesn't return children array #9030

Closed
level420 opened this issue Jun 1, 2016 · 2 comments · Fixed by #9032
Closed

qx.ui.toolbar.Toolbar.removeAll() doesn't return children array #9030

level420 opened this issue Jun 1, 2016 · 2 comments · Fixed by #9032
Assignees
@level420
Labels
bug Errors
Milestone
release_5_0_2

Comments

@level420
Copy link
Member

level420 commented Jun 1, 2016

qx.ui.toolbar.Toolbar.removeAll() doesn't return children array,
returns undefined instead

quick fix:

ToolBar.js

// overridden
_removeAll : function() {
  var ret = this.base(arguments);
  this._recalculateOverflow(null, 0);
  return ret;
},

Regards, Johannes
@level420
Copy link
Member Author

level420 commented Jun 1, 2016

Originaly reported on old bugzilla.

@level420
Copy link
Member Author

level420 commented Jun 1, 2016

This is a discrepancy between the api documentation
https://github.com/qooxdoo/qooxdoo/blob/4bfad7f/framework/source/class/qx/ui/core/MChildrenHandling.js#L173
and the implementation:
https://github.com/qooxdoo/qooxdoo/blob/4bfad7f/framework/source/class/qx/ui/toolbar/ToolBar.js#L596

level420 added a commit that referenced this issue Jun 1, 2016
@level420
Return removed children in _removeAll
128178b 
as documented in https://github.com/qooxdoo/qooxdoo/blob/4bfad7f/framework/source/class/qx/ui/core/MChildrenHandling.js#L173

fixes #9030
This was referenced Jun 1, 2016
Closed
Merged
@level420 level420 self-assigned this Jun 1, 2016
@johnspackman johnspackman added this to the release_5_0_2 milestone Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@level420 level420

Labels
bug Errors
Projects
None yet
Milestone
release_5_0_2
Development

Successfully merging a pull request may close this issue.

Return removed children in _removeAll
Return removed children in _removeAll qooxdoo/qooxdoo
2 participants
@johnspackman @level420