Return removed children in _removeAll

[level420]

as documented in https://github.com/qooxdoo/qooxdoo/blob/4bfad7f/framework/source/class/qx/ui/core/MChildrenHandling.js#L173

fixes #9030

[level420]

Sorry! Accidently created a branch in https://github.com/qooxdoo/qooxdoo

[oetiker]

looks good ... since adding a return value to a function that did NOT have a return value, should not have any negative impact IMHO ... but lets see if the tests agree

[cajus]

+1 from here, too

[level420]

I meant the fact that I created a branch in qooxdoo/qooxdoo and not in my fork. Is this something odd?

[oetiker]

you can just remove the branch after merging no harm done

[cajus]

Just remove the branch after it's merged. I don't see a problem there.

[oetiker]

https://github.com/qooxdoo/qooxdoo/branches

[level420]

I was worried about the two travis runs.

[oetiker]

one is for the new branch and one is for the PR

[oetiker]

what IS interesting that the new branch caused a rebuild of the website ... @cajus

[woprandi]

You should maybe add a unit test for that

[oetiker]

then the coverage would not drop :)

[level420]

Yes! I will add a unit test for that asap. But now from my fork :-(

[woprandi]

Yeah, and also because it is a good practice to always add a unit test to prevent a bug to come-back :)

[level420]

So should I create a new PR based on my fork including the test or just merge this and create another PR with the test?

[coveralls]

Coverage decreased (-0.003%) to 55.639% when pulling 128178b on level420-issue-9030 into e0530f4 on master.

[level420]

Closing this one and creating a new one based on my fork.