Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qore can set the wrong default zone offset for time zones #168

Closed
davidnich opened this issue Nov 23, 2015 · 0 comments
Closed

qore can set the wrong default zone offset for time zones #168

davidnich opened this issue Nov 23, 2015 · 0 comments
Assignees
@davidnich
Labels
bug fixed
Milestone
0.8.12

Comments

@davidnich
Copy link
Contributor

because it takes the earliest non DST offset as the default offset instead of the latest

this causes TimeZone::UTCOffset() to return an invalid value
ex:

qore -X '(new TimeZone("Europe/Prague")).UTCOffset()'
3464

3564 is the first value in the file valid from 1849 - 1891
@davidnich davidnich added the bug label Nov 23, 2015
@davidnich davidnich self-assigned this Nov 23, 2015
@davidnich davidnich modified the milestones: 0.8.12, 0.8.11.x Nov 23, 2015
davidnich added a commit that referenced this issue Nov 24, 2015
@davidnich
refs #168 the default UTC offset is set from the last time band in th…
b81592e 
…e zone file, not the first - historical time bands may have different UTC offsets, tests added

refs #170 tests & release notes updated from hotfix
refs #172 added support for paths to zoneinfo files if PO_NO_FILESYSTEM is not set, test added
date.qtest ported to QUnit
@davidnich davidnich mentioned this issue Nov 24, 2015
Merged
@tethal tethal added the fixed label Nov 24, 2015
@tethal tethal closed this as completed Nov 24, 2015
tethal added a commit that referenced this issue Nov 24, 2015
@tethal
Merge pull request #174 from qorelanguage/bugfix/168_170_172_timezone…
1cb6624 
…_fixes

fixes #168, #170, and #172 - time zone handling fixes + updated tests + relnotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidnich davidnich

Labels
bug fixed
Projects
None yet
Milestone
0.8.12
Development

No branches or pull requests
2 participants
@tethal @davidnich