Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update RestHandler to provide an alternate URI path for actions #2994

Closed
davidnich opened this issue Sep 15, 2018 · 0 comments
Closed

update RestHandler to provide an alternate URI path for actions #2994

davidnich opened this issue Sep 15, 2018 · 0 comments
Labels
feature fixed not-c++
Milestone
0.9

Comments

@davidnich
Copy link
Contributor

davidnich commented Sep 15, 2018 •
edited
Loading

to be compatible with REST schemas such as Swagger / OAS

ex:
from:

hash<auto> putUpdate(hash<auto> cx, *hash<auto> ah) {
    # ...
}

instead of just:
PUT path?action=update

the following will also be supported:
PUT path/update
@davidnich davidnich added this to the 0.9 milestone Sep 15, 2018
davidnich added a commit that referenced this issue Sep 16, 2018
@davidnich
refs #2994 Updated to support alternative URI paths for actions so th…
a409b6a 
…at an "action=xxx"

argument is not needed; instead the action can be added to the end of the URI path so
that "PUT path/xxx" can be used instead of "PUT path?action=xxx"
davidnich added a commit that referenced this issue Sep 16, 2018
@davidnich
refs #2994 only look for action methods for URI paths if the subclass…
20105be 
… match fails to avoid compatibility problems
davidnich added a commit that referenced this issue Sep 16, 2018
@davidnich
refs #2994 improved docs; added a note that requiring action argument…
3777ab1 
…s is not recommended; updated argument example
davidnich added a commit that referenced this issue Sep 16, 2018
@davidnich
refs #2994 doc updates
1e6990c
sejvlond pushed a commit that referenced this issue Sep 20, 2018
@davidnich @sejvlond
refs #2994 Updated to support alternative URI paths for actions so th… (
0f8a25b 
#2997)

* refs #2994 Updated to support alternative URI paths for actions so that an "action=xxx"
argument is not needed; instead the action can be added to the end of the URI path so
that "PUT path/xxx" can be used instead of "PUT path?action=xxx"
* refs #2994 only look for action methods for URI paths if the subclass match fails to avoid compatibility problems
* refs #2994 improved docs; added a note that requiring action arguments is not recommended; updated argument example
davidnich added a commit that referenced this issue Sep 21, 2018
@davidnich
refs #2994 more consistent arugment handling for REST URI path action…
189e6d7 
…s; added tests
davidnich added a commit that referenced this issue Sep 23, 2018
@davidnich
refs #2994 fixed subclass matching in the root class; greatly improve…
e0f9c0b 
…d error reeporting
davidnich added a commit that referenced this issue Sep 24, 2018
@davidnich
refs #2994 fixed an error with REST methods as HTTP verbs
07bf726
sejvlond added a commit that referenced this issue Sep 25, 2018
@sejvlond
Merge pull request #3011 from qorelanguage/bugfix/2994_REST_URI_path_fix
7c22b26 
refs #2994 more consistent arugment handling for REST URI path action…
petrycta pushed a commit that referenced this issue Oct 10, 2018
@davidnich @petrycta
refs #2994 Updated to support alternative URI paths for actions so th… (
f7b3eb2 
#2997)

* refs #2994 Updated to support alternative URI paths for actions so that an "action=xxx"
argument is not needed; instead the action can be added to the end of the URI path so
that "PUT path/xxx" can be used instead of "PUT path?action=xxx"
* refs #2994 only look for action methods for URI paths if the subclass match fails to avoid compatibility problems
* refs #2994 improved docs; added a note that requiring action arguments is not recommended; updated argument example
petrycta pushed a commit that referenced this issue Oct 10, 2018
@davidnich @petrycta
refs #2994 more consistent arugment handling for REST URI path action…
69317ec 
…s; added tests
petrycta pushed a commit that referenced this issue Oct 10, 2018
@davidnich @petrycta
refs #2994 fixed subclass matching in the root class; greatly improve…
e2228de 
…d error reeporting
petrycta pushed a commit that referenced this issue Oct 10, 2018
@davidnich @petrycta
refs #2994 fixed an error with REST methods as HTTP verbs
dc389fb
davidnich added a commit that referenced this issue Jan 2, 2019
@davidnich
refs #2994 fixed issues related to improved method matching; allow st…
fc741b1 
…atic lookups to be used everywhere in the REST hierarchy instead of just in the base handler object
davidnich added a commit that referenced this issue Jan 2, 2019
@davidnich
reffs #2994 fixed a longstanding existing typo in an exception
461ff60
davidnich added a commit that referenced this issue Jan 2, 2019
@davidnich
refs #2994 updated docs about REST call argument handling
fa42b33
davidnich added a commit that referenced this issue Jan 2, 2019
@davidnich
Merge pull request #3217 from qorelanguage/bugfix/2994_RestHandler_fix
07b9fb6 
refs #2994 fixed issues related to improved method matching; allow st…
davidnich added a commit that referenced this issue Jan 2, 2019
@davidnich
refs #2994 fixed comments in RestHandler
8317e61
davidnich added a commit that referenced this issue Jan 3, 2019
@davidnich
refs #2994 do not move the default get handler to AbstractRestClass -…
19e1307 
… leave it in RestHandler
davidnich added a commit that referenced this issue Jan 3, 2019
@davidnich
refs #2994 fixed comments in RestHandler (#3218)
5293fcd 
* refs #2994 fixed comments in RestHandler

* refs #2994 do not move the default get handler to AbstractRestClass - leave it in RestHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature fixed not-c++
Projects
None yet
Milestone
0.9
Development

No branches or pull requests
1 participant
@davidnich