fixed #1684 sqlutil: schema alignment skips column with name "driver" #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnich
requested changes
Feb 22, 2017
| @@ -2,6 +2,16 @@ | |||
|
|
|||
| @tableofcontents | |||
|
|
|||
| @section qore_08129 Qore 0.8.12.9 | |||
There was a problem hiding this comment.
0.8.12.8 is the next (unreleased) version, please move these notes there
qlib/SqlUtil.qm
Outdated
| @@ -101,6 +101,9 @@ module SqlUtil { | |||
| @section sqlutil_relnotes Release Notes for the SqlUtil Module | |||
|
|
|||
| @subsection sqlutilv1_3_1 SqlUtil v1.3.1 | |||
| - fixed schema alignment skips column with name "driver" (<a href="https://github.com/qorelanguage/qore/issues/1684">issue 1684</a>) | |||
There was a problem hiding this comment.
please update to 1.3.2 and also update the module version in the header
qlib/SqlUtil.qm
Outdated
| # Do not handle checkDriverOptions for columns hash. | ||
| # Driver is a potential valid column name. Column sub-hashes | ||
| # are handled in next section. | ||
| #AbstractDatabase::checkDriverOptions(\desc.columns, drv); |
There was a problem hiding this comment.
I think we should remove this line entirely instead of commenting it out - it should either be there or not and the comments above explain why
davidnich
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.