Adding support for Throwable.getSuppressed(). #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See http://www.oracle.com/technetwork/articles/java/trywithresources-401775.html - Removed superfluous public from methods in IThrowableProxy interface and added method IThrowableProxy[] getSuppressed(). - Serialized ThrowableProxyVO will be incompatible since suppressed has been added. Consequently, the respective serialVersionUID has been changed. - ThrowableProxyVO.equals is now also checking suppressed. - ThrowableProxy is now evaluating suppressed Throwables of its c'tor argument if the Throwable class has a getSuppressed() method, i.e. in case of Java SE 7 and upwards. This patch is merely adding support of suppressed exceptions to the creation of LoggingEvent/IThrowableProxy. Further support should be added to the following classes: - ch.qos.logback.classic.db.DBAppender - ch.qos.logback.classic.html.DefaultThrowableRenderer - ch.qos.logback.classic.net.SyslogAppender - ch.qos.logback.classic.pattern.ThrowableProxyConverter - ch.qos.logback.classic.spi.ThrowableProxyUtil - method asString - ch.qos.logback.classic.spi.PackagingDataCalculator - method calculate(IThrowableProxy tp) may also need to take suppressed into account.
calculate(IThrowableProxy), as expected, needs to support suppressed Throwables, too. All of this has been tested with Java 7 b145 and is working as expected.
|
I tested this on Java 7 b145 and everything works as expected. |
huxi
added a commit
that referenced
this pull request
Nov 4, 2011
Adding support for Throwable.getSuppressed().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://www.oracle.com/technetwork/articles/java/trywithresources-401775.html
This patch is merely adding support of suppressed exceptions to the creation of LoggingEvent/IThrowableProxy. Further support should be added to the following classes: