Throw exception if configuration file has unexpected extension #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extension (not .xml or .groovy)
|
Updated code style as requested |
tony19
pushed a commit
that referenced
this pull request
Jan 21, 2014
Throw exception for unexpected file extension for config
tony19
added a commit
that referenced
this pull request
Jan 21, 2014
Add note for pull request #38 -- throw exception for unknown config file extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We recently had an issue where our Logback XML configuration file (specified via a system property) didn't have the extension ".xml". This didn't work, but we didn't get any feedback on it (other than no entries in our log file).
This change (with included unit tests) makes logback-classic throw an exception when provided with a file without the appropriate extension.
Sincerely,
Halvard