Use getter methods for singleton instances in *Binder classes #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stances, falling back to public field if absent.
| @@ -37,7 +37,16 @@ | |||
| /** | |||
| * The unique instance of this class. | |||
| */ | |||
| public static final StaticMDCBinder SINGLETON = new StaticMDCBinder(); | |||
There was a problem hiding this comment.
I'm not sure about making this private right now. Perhaps mark it as @deprecated instead so people know to switch to accessor method.
|
Thanks @mattbishop - I've updated the PR |
|
Fixed by ea3cca7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to JIRA issue SLF4J-347