-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few toolchains etc. tweaks to try and get Travis build working #187
Conversation
…lugin on Travis. Note that Travis will not support maven-toolchains-plugin, see travis-ci/travis-ci#2727 .
Any feedback on this effort to make the Travis build succeed for |
Raised https://jira.qos.ch/browse/SLF4J-427 . |
Up until a few weeks ago, logback** was built using Java 9 (without toolchains) with Java 7 as the target JDK. While compilation, testing and artifact creation works under this structure, javadocs cannot be produced under Java 9. In turn, this precludes releases on Maven central (because it checks whether the release has javadoc artifacts). At present time, the only way to make a valid built is with toolchains where Java7 is the default JDK. If understand correctly, Travis does not support toolchains. While I care about Travis, I care a lot more about having valid/releasable builds. At this stage, I am very hesitant to modify slf4j pom.xml files until Maven+Java9 crap is sorted out. **SLF4J's Maven is quite similar to logback. |
Doh. Your idea is to disable toolchains only for Travis. |
Yes this is primarily about Travis builds when It is possible that the Travis build can be further improved with some matrix config to handle the different JDK requirements. This only attempts to put it back to passing in the first instance. |
I had to inverse Java 1.6/Java 9 declaration in the element in . This allows javadoc to be built. Apparently, the last jdk declaration becomes the default for other plugins. And Travis build passes as well. :-) |
Ah good catch, I would not have expected that.
'Tis good to see, thanks! |
Travis build on master has been down for a bit. This change:
dist
totrusty
.oraclejdk9
in Travis because we now depend on it.maven-toolchains-plugin
when running in Travis, they won't support it, see Support Maven Toolchains travis-ci/travis-ci#2727 .