Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few toolchains etc. tweaks to try and get Travis build working #187

Merged
merged 3 commits into from
Jan 30, 2018

Conversation

javabrett
Copy link
Contributor

@javabrett javabrett commented Nov 11, 2017

Travis build on master has been down for a bit. This change:

@javabrett
Copy link
Contributor Author

javabrett commented Nov 16, 2017

Any feedback on this effort to make the Travis build succeed for master?

@javabrett
Copy link
Contributor Author

Raised https://jira.qos.ch/browse/SLF4J-427 .

@ceki
Copy link
Member

ceki commented Jan 30, 2018

Up until a few weeks ago, logback** was built using Java 9 (without toolchains) with Java 7 as the target JDK. While compilation, testing and artifact creation works under this structure, javadocs cannot be produced under Java 9. In turn, this precludes releases on Maven central (because it checks whether the release has javadoc artifacts).

At present time, the only way to make a valid built is with toolchains where Java7 is the default JDK. If understand correctly, Travis does not support toolchains. While I care about Travis, I care a lot more about having valid/releasable builds.

At this stage, I am very hesitant to modify slf4j pom.xml files until Maven+Java9 crap is sorted out.

**SLF4J's Maven is quite similar to logback.

@ceki
Copy link
Member

ceki commented Jan 30, 2018

Doh. Your idea is to disable toolchains only for Travis.

@javabrett
Copy link
Contributor Author

Yes this is primarily about Travis builds when env.TRAVIS is set, activating that profile. It is a quick-and-dirty fix that should only impact the Travis build, which whilst not critical, is a nice-to-have and helps identify build-failures and problems with PRs.

It is possible that the Travis build can be further improved with some matrix config to handle the different JDK requirements. This only attempts to put it back to passing in the first instance.

@ceki ceki merged commit a8aa783 into qos-ch:master Jan 30, 2018
@ceki
Copy link
Member

ceki commented Jan 30, 2018

I had to inverse Java 1.6/Java 9 declaration in the element in . This allows javadoc to be built. Apparently, the last jdk declaration becomes the default for other plugins.

And Travis build passes as well. :-)

@javabrett
Copy link
Contributor Author

I had to inverse Java 1.6/Java 9 declaration in the element in . This allows javadoc to be built. Apparently, the last jdk declaration becomes the default for other plugins.

Ah good catch, I would not have expected that.

And Travis build passes as well. :-)

'Tis good to see, thanks!

@javabrett javabrett deleted the travis branch January 30, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants