do not crash the GraphViz formatter if no config is given #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gennadigennadigennadi
approved these changes
Jul 21, 2023
github-merge-queue bot
pushed a commit
to Lendable/aggregate
that referenced
this pull request
May 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [qossmic/deptrac](https://togithub.com/qossmic/deptrac) | `^2.0.0-alpha` -> `^2.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>qossmic/deptrac (qossmic/deptrac)</summary> ### [`v2.0.0`](https://togithub.com/qossmic/deptrac/releases/tag/2.0.0) [Compare Source](https://togithub.com/qossmic/deptrac/compare/2.0.0-alpha...2.0.0) #### What's Changed - Bundle open dependency updates together by [@​dbrumann](https://togithub.com/dbrumann) in [qossmic/deptrac#1070 - Exception clean up by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1079 - Extension documentation by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#867 - Installation guide improved and aligned. by [@​d4s6](https://togithub.com/d4s6) in [qossmic/deptrac#1076 - Bump phpunit/phpunit from 9.5.27 to 9.5.28 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1080 - Bump phpstan/phpstan-symfony from 1.2.19 to 1.2.20 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1081 - Bump phpstan/phpstan from 1.9.11 to 1.9.13 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1083 - Use getOption instead getParameterOption on config file by [@​maciejkosiarski](https://togithub.com/maciejkosiarski) in [qossmic/deptrac#1089 - Fix --help doesn't work if deptrac.yaml file is missing issue by [@​maciejkosiarski](https://togithub.com/maciejkosiarski) in [qossmic/deptrac#1088 - Mutation coverage improvements by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1090 - Override --help input option and add throws annotation according to psalm audit by [@​maciejkosiarski](https://togithub.com/maciejkosiarski) in [qossmic/deptrac#1092 - Bump phpstan/phpstan from 1.9.13 to 1.9.17 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1111 - Bump phpstan/phpdoc-parser from 1.15.3 to 1.16.1 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1110 - Bump friendsofphp/php-cs-fixer from 3.13.2 to 3.14.4 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1109 - Bump phpunit/phpunit from 9.5.28 to 9.6.3 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1107 - Bump symfony/dependency-injection from 6.2.3 to 6.2.6 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1108 - Bump phpstan/phpstan-symfony from 1.2.20 to 1.2.23 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1106 - Bump symfony/finder from 6.2.3 to 6.2.5 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1093 - Bump symfony/console from 6.2.3 to 6.2.5 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1101 - Bump symfony/filesystem from 6.2.0 to 6.2.5 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1100 - Bump symfony/yaml from 6.2.2 to 6.2.5 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1099 - Bump symfony/event-dispatcher from 6.2.2 to 6.2.5 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1097 - Bump symfony/config from 6.2.0 to 6.2.5 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1095 - Bump symfony/options-resolver from 6.2.0 to 6.2.5 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1094 - Bump nikic/php-parser from 4.15.2 to 4.15.3 by [@​dependabot](https://togithub.com/dependabot) in [qossmic/deptrac#1087 - Updating Result generation by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1091 - Code hardening - solving baseline issues in SA tools by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1103 - \[rector] Prepare PHP 7.2 downgrade + scoped release with Rector by [@​TomasVotruba](https://togithub.com/TomasVotruba) in [qossmic/deptrac#1113 - Updated CollectorInterface namespace in docs by [@​ariddlestone](https://togithub.com/ariddlestone) in [qossmic/deptrac#1120 - Better Violations by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1105 - Update configuration.md typo by [@​gusdeboer](https://togithub.com/gusdeboer) in [qossmic/deptrac#1140 - Update dependencies by [@​dbrumann](https://togithub.com/dbrumann) in [qossmic/deptrac#1141 - Implement ConfigBuilder by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1002 - Add performance counters to ConsoleSubsriber by [@​rubenrubiob](https://togithub.com/rubenrubiob) in [qossmic/deptrac#1162 - Migrated `debug:unused` command from deptrac-awesome by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1164 - Migrated `debug:dependencies` command from deptrac-awesome by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1165 - Combine updates by [@​dbrumann](https://togithub.com/dbrumann) in [qossmic/deptrac#1171 - Sort make targets and introduce help by [@​dbrumann](https://togithub.com/dbrumann) in [qossmic/deptrac#1176 - Composer Collector by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1174 - PoC blog by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1178 - add docker setup and move cache-files into .cache/ by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1185 - [#​1158](https://togithub.com/qossmic/deptrac/issues/1158) - only read file once for filereader by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1192 - [#​1158](https://togithub.com/qossmic/deptrac/issues/1158) - only init new ComposerFileParser once per composer.lock by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1193 - Call `SuperGlobalToken::allowedNames()` just once by [@​staabm](https://togithub.com/staabm) in [qossmic/deptrac#1198 - Removing deprecations and other clean-up for new Major release by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1175 - Bump composer dep by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1216 - add php-cs-fixer rule "single_line_empty_body" by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1217 - Closes [qossmic/deptrac#1191 by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1204 - fix [#​1226](https://togithub.com/qossmic/deptrac/issues/1226) - skipped multiple violations in one file by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1227 - "deptrac" as composer bin by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1238 - do not crash the GraphViz formatter if no config is given by [@​xabbuh](https://togithub.com/xabbuh) in [qossmic/deptrac#1251 - Dev dependencies upgrade (PHPUnit & Psalm) by [@​patrickkusebauch](https://togithub.com/patrickkusebauch) in [qossmic/deptrac#1252 - Docs: exclude_files also works on directories by [@​staabm](https://togithub.com/staabm) in [qossmic/deptrac#1262 - Prevent excessive php-doc parsing in FileReferenceVisitor by [@​staabm](https://togithub.com/staabm) in [qossmic/deptrac#1199 - Composer collector exception when package does not exist by [@​maciejkosiarski](https://togithub.com/maciejkosiarski) in [qossmic/deptrac#1279 - Update dep by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1280 - Fix typo in the docs by [@​jdreesen](https://togithub.com/jdreesen) in [qossmic/deptrac#1281 - Add creating of cache directory if not exists by [@​alexander-schranz](https://togithub.com/alexander-schranz) in [qossmic/deptrac#1302 - Remove dollar signs from readme.md console examples by [@​that-guy-iain](https://togithub.com/that-guy-iain) in [qossmic/deptrac#1325 - Bump PHP Parser version to support PHP 8.3 by [@​benr77](https://togithub.com/benr77) in [qossmic/deptrac#1342 - bump composer.lock by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1344 - WIP: test scoped release by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1352 - update by [@​gennadigennadigennadi](https://togithub.com/gennadigennadigennadi) in [qossmic/deptrac#1406 #### New Contributors - [@​d4s6](https://togithub.com/d4s6) made their first contribution in [qossmic/deptrac#1076 - [@​maciejkosiarski](https://togithub.com/maciejkosiarski) made their first contribution in [qossmic/deptrac#1089 - [@​TomasVotruba](https://togithub.com/TomasVotruba) made their first contribution in [qossmic/deptrac#1113 - [@​ariddlestone](https://togithub.com/ariddlestone) made their first contribution in [qossmic/deptrac#1120 - [@​gusdeboer](https://togithub.com/gusdeboer) made their first contribution in [qossmic/deptrac#1140 - [@​rubenrubiob](https://togithub.com/rubenrubiob) made their first contribution in [qossmic/deptrac#1162 - [@​jdreesen](https://togithub.com/jdreesen) made their first contribution in [qossmic/deptrac#1281 - [@​alexander-schranz](https://togithub.com/alexander-schranz) made their first contribution in [qossmic/deptrac#1302 - [@​that-guy-iain](https://togithub.com/that-guy-iain) made their first contribution in [qossmic/deptrac#1325 - [@​benr77](https://togithub.com/benr77) made their first contribution in [qossmic/deptrac#1342 **Full Changelog**: qossmic/deptrac@1.0.2...2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/aggregate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #951 did not fully fix #949. Reason for this is that the Symfony container compiler skips loading extensions for which no configuration has been made. This in turn means that the Deptrac Configuration class is never processed and its default values are not being populated.