New version 5.7.6 #211

phoebe-p · 2022-03-23T04:32:12Z

No description provided.

…s, infra, maintenance, review, test (#172) * docs: update README.md [skip ci] * docs: create .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: update README.md [skip ci] * docs: create .all-contributorsrc [skip ci] * Fix all contributors stuff Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* Added the function that install numpy before everything * Ignoring Codacy * Removed pre-installation of numpy due to the installing during setup fase * Modified the docs reflecting the change (numpy not needed)

* Correct some typos * Add options for DA solver * Add Green's function approximation for the DA solver * Remove unused variable * Use adaptive integration (closer to existing impl, allows for rtol) * Correct some typos * Exclude endpoint from integration (similar to solve_bvp method) * Guard Green's method from extreme L values * Add docstring in diffusion Green function * Add science reference in diffusion Green function * Move convolution integral function to top level * Remove constant terms from convolution and reduce function args * Docstring for functions computing the convolution integrals * Add tests * Update docs Co-authored-by: thomas <thomas@thomasDebian.WORKGROUP> Co-authored-by: thomas <thomas@thomasDebian>

…ers)

Co-authored-by: Diego Alonso Álvarez <d.alonso-alvarez@imperial.ac.uk>

…5 into examples_docs

Update documentation

codecov · 2022-03-23T04:34:16Z

Codecov Report

Merging #211 (ef37a0e) into master (80a2602) will increase coverage by 0.38%.
The diff coverage is 93.47%.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   45.47%   45.85%   +0.38%     
==========================================
  Files          84       84              
  Lines        9029     9100      +71     
==========================================
+ Hits         4106     4173      +67     
- Misses       4923     4927       +4

Impacted Files	Coverage Δ
solcore/light_source/smarts.py	`11.45% <0.00%> (ø)`
solcore/optics/rcwa.py	`23.88% <0.00%> (ø)`
solcore/science_tracker.py	`26.53% <ø> (ø)`
solcore/structure.py	`91.75% <ø> (ø)`
solcore/optics/beer_lambert.py	`50.00% <73.33%> (+2.00%)`	⬆️
solcore/absorption_calculator/tmm_core_vec.py	`100.00% <100.00%> (ø)`
solcore/analytic_solar_cells/__init__.py	`100.00% <100.00%> (ø)`
...re/analytic_solar_cells/depletion_approximation.py	`100.00% <100.00%> (ø)`
solcore/optics/tmm.py	`91.35% <100.00%> (ø)`
solcore/solar_cell_solver.py	`66.46% <100.00%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a2602...ef37a0e. Read the comment docs.

…g BL law

…orption

dalonsoa

Let's merge the other branch, first and then go for this one.

Change layer absorption calculation for BL optics

phoebe-p · 2022-04-01T00:34:04Z

What is the "correct" way to do this? I guess we want to make a new version, so should I bump the version (in conf.py, setup.cfg and solcore_config.txt) in develop first and then merge that into master? Also, for the documentation, I am not sure which branches it is currently tracking but I think it's master and devel (not sure what "latest" means), but we don't use devel anymore, so I think this should be changed to tracking develop. I think this has to be updated on readthedocs directly, not sure I am able to access that?

dalonsoa · 2022-04-01T07:04:59Z

We are using a tool called bump2version that does the bumping for us in the correct places (as configured in setup.cfg), commit the changes and creates a tag.

I would do the following:

Merge develop into master and pull the latest version of master to your computer.
Use bump2version to bump the version locally.
Push the new commit and the new tag back to the repo with git push and git push --tags, respectively.
Create a new release in GitHub, selecting the new tag and creating automatic release notes as described here.
Merge master into develop.

About Read The Docs, let me check what is tracking. I'll see if I can transfer you the control of it or, at the very least, give you access.

allcontributors bot and others added 30 commits September 30, 2021 11:41

Fix all cont (#178)

8dcd86d

* docs: update README.md [skip ci] * docs: create .all-contributorsrc [skip ci] * Fix all contributors stuff Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add PieceMaker as a contributor for test, review (#179)

91a425f

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add mhrownaghi as a contributor for test, code (#180)

afe5480

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add federikovi as a contributor for example (#181)

65514d5

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add Artyko as a contributor for code (#182)

8aae2e3

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add emmanuel-carreira as a contributor for example (#183)

9481581

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add NimishVerma as a contributor for example (#184)

817eb4b

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add P-Tillmann as a contributor for code, bug, test (#185)

57734cc

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add jmllorens as a contributor for code, bug, test (#186)

8a469a5

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add Abelarm as a contributor for code, infra (#187)

d11172c

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add MichaelNOz as a contributor for code (#189)

e82dcd5

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add hrishikeshSuresh as a contributor for example (#190)

2b05036

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add jscooksey as a contributor for example (#191)

cd2c41b

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add yuriy-os as a contributor for design (#193)

b5df0d5

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add canns99 as a contributor for bug (#194)

c8552dc

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add AndiPOz as a contributor for bug (#195)

f7d573e

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

Amend contributors's list

ac61307

docs: add Rushil17D070020 as a contributor for bug (#196)

fb0e766

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add etervo as a contributor for bug (#197)

f874669

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

Add data to Diego

15473f6

Add data to several

15153ce

Add data to Markus

1773744

Add full name

760eddb

Remove the need of installing numpy manually before installing Solcore

2ca5ffb

* Added the function that install numpy before everything * Ignoring Codacy * Removed pre-installation of numpy due to the installing during setup fase * Modified the docs reflecting the change (numpy not needed)

fix warnings caused by tmm_core_vec

26127ba

fix accidentally empty external_optics.py example

3d2f6fd

🐛 fix tests with incorrect usage of 'assert'

a6b067a

🐛 fix another failing test (small absolute error for almost-zero numb…

883a31a

…ers)

phoebe-p and others added 12 commits March 17, 2022 16:14

📝 update/clarify installation instructions

b516dba

📝 fix some outdated examples, update docs further

1004865

📝 update .gitignore, installation instructions

553ad41

delete .DS_Store

5669200

📝 fix minor issues in examples (in examples folder and in docs).

5cf9298

remove print statement used to debug

c876ad1

Update docs/source/Installation/installation.rst

44fd0cc

Co-authored-by: Diego Alonso Álvarez <d.alonso-alvarez@imperial.ac.uk>

Update docs/source/Examples/example_3J_with_DA_solver.rst

286b17c

Co-authored-by: Diego Alonso Álvarez <d.alonso-alvarez@imperial.ac.uk>

📝 update instructions for WSL

90a526d

Merge branch 'examples_docs' of github.com:qpv-research-group/solcore…

909655d

…5 into examples_docs

📝 typos, initial pip and setuptools instructions

502e635

Merge pull request #210 from qpv-research-group/examples_docs

29593db

Update documentation

phoebe-p requested a review from dalonsoa March 23, 2022 04:32

phoebe-p added 7 commits March 24, 2022 11:13

analytical rather than numerical calculation of total absorption usin…

b6de310

…g BL law

same examples in notebooks and .py files, change hanging parallel test

e6941c6

remove output of notebooks

75a418d

🐎 don't need to compute layer positions if not integrating for BL abs…

69b2a8f

…orption

fix incorrect heading in testing workflow

c7da77f

testing

eac6f20

new BL layer absorption calculation working as expected

d672071

dalonsoa approved these changes Mar 24, 2022

View reviewed changes

phoebe-p added 5 commits March 25, 2022 11:11

exclude PDD tests explicitly for Windows

cb3ade5

Actually run tests in windows....

f6155b3

Merge branch 'fix_failing_tests' into BL_abs_fix

d27c61b

define variable for layer index

a81dd84

Merge pull request #213 from qpv-research-group/BL_abs_fix

ef37a0e

Change layer absorption calculation for BL optics

phoebe-p merged commit 21d247a into master Apr 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New version 5.7.6 #211

New version 5.7.6 #211

phoebe-p commented Mar 23, 2022

codecov bot commented Mar 23, 2022 •

edited

dalonsoa left a comment

phoebe-p commented Apr 1, 2022

dalonsoa commented Apr 1, 2022 •

edited

New version 5.7.6 #211

New version 5.7.6 #211

Conversation

phoebe-p commented Mar 23, 2022

codecov bot commented Mar 23, 2022 • edited

Codecov Report

dalonsoa left a comment

Choose a reason for hiding this comment

phoebe-p commented Apr 1, 2022

dalonsoa commented Apr 1, 2022 • edited

codecov bot commented Mar 23, 2022 •

edited

dalonsoa commented Apr 1, 2022 •

edited