Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the refactoring of the code in
solar_cell_solver.py
such that it uses registered functions within a set of registries to execute different calculations rather than hardcoding the functionality.Among other things, using registries enables:
sunglass
)This PR concerns the implementation of the top level ACTIONS of the solar cell solver. PRs for the optical, IV, QE, etc. solvers will follow.
There seems to be lot's of changes because the
solar_cell_solver.py
file got reformatted byblack
, but the only important bit in that file is the functionsolve_solar_cell
.