Optics registry #232
Merged
Optics registry #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #232 +/- ##
===========================================
+ Coverage 45.76% 46.03% +0.26%
===========================================
Files 84 85 +1
Lines 9096 9120 +24
===========================================
+ Hits 4163 4198 +35
+ Misses 4933 4922 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phoebe-p
approved these changes
Oct 27, 2022
solcore/optics/beer_lambert.py
Outdated
| else: | ||
| ASC.absorptance_detailed_balance(solar_cell[j]) | ||
| w = layer_object.width | ||
|
|
||
| def alf(x): | ||
| return -1 / w * np.log(np.maximum(1 - layer_object.absorptance(x), 1e-3)) | ||
| return ( |
There was a problem hiding this comment.
This is very minor and I guess it was done by black, I am fine with it, but the return here ooks a bit weird/harder to read than before? Anyway, if black will just keep changing it back then it will be pointless to do anything about it!
There was a problem hiding this comment.
In that particular case, I think it makes sense to use some intermediate variables to make the code more readable. Solved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #231, this PR creates a registry of the optics methods, refactoring the function methods to make them more readable and explicit on their inputs. It also refactors
solar_cell_solver.pyto make use of this registry.Must be reviewed after #231, as it builds on top of it.