Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equilibrium solver registry and updates equilibrium_pdd #235

Merged
merged 6 commits into from Dec 12, 2022

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Nov 5, 2022

Creates the equilibrium solver registry and updates the equilibrium_pdd function to use it. As a bonus, the ProcessStructure function has also been refactored, leaving the code a bit cleaner and better structured. Docstrings have been improved in both cases.

@phoebe-p , ignore the changes in the Jupyter notebook files - that has been a side effect of running the pre-commit hooks, in charge - among other things - of stripping notebooks of some metadata that changes every time they are open. Nothing to do with the actual changes described above.

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #235 (39f7d0b) into develop (de18f91) will decrease coverage by 0.02%.
The diff coverage is 76.00%.

@@             Coverage Diff             @@
##           develop     #235      +/-   ##
===========================================
- Coverage    46.07%   46.05%   -0.03%     
===========================================
  Files           85       85              
  Lines         9133     9135       +2     
===========================================
- Hits          4208     4207       -1     
- Misses        4925     4928       +3     
Impacted Files Coverage Δ
solcore/solar_cell_solver.py 69.51% <14.28%> (-1.30%) ⬇️
...poisson_drift_diffusion/DriftDiffusionUtilities.py 85.88% <100.00%> (-0.28%) ⬇️
solcore/registries.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dalonsoa dalonsoa mentioned this pull request Nov 30, 2022
@dalonsoa dalonsoa merged commit 2ff25da into develop Dec 12, 2022
@dalonsoa dalonsoa deleted the register_equilibrium_solver branch December 12, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant