Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the IV registry #239

Merged
merged 9 commits into from Dec 12, 2022
Merged

Create the IV registry #239

merged 9 commits into from Dec 12, 2022

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Nov 30, 2022

Creates the IV solver's registry and complete the tests for the registers, which were missing.

This should be reviewed and merged after #235

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #239 (03b64dc) into develop (de18f91) will increase coverage by 1.16%.
The diff coverage is 79.31%.

@@             Coverage Diff             @@
##           develop     #239      +/-   ##
===========================================
+ Coverage    46.07%   47.23%   +1.16%     
===========================================
  Files           85       85              
  Lines         9133     9342     +209     
===========================================
+ Hits          4208     4413     +205     
- Misses        4925     4929       +4     
Impacted Files Coverage Δ
solcore/solar_cell_solver.py 69.51% <14.28%> (-1.30%) ⬇️
...poisson_drift_diffusion/DriftDiffusionUtilities.py 85.88% <100.00%> (-0.28%) ⬇️
solcore/registries.py 97.14% <100.00%> (-2.86%) ⬇️
solcore/absorption_calculator/tmm_core_vec.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dalonsoa dalonsoa mentioned this pull request Dec 1, 2022
@dalonsoa dalonsoa closed this Dec 12, 2022
@dalonsoa dalonsoa reopened this Dec 12, 2022
@dalonsoa dalonsoa merged commit 89cbd9e into develop Dec 12, 2022
@dalonsoa dalonsoa deleted the register_iv_solvers branch December 12, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant