Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the IV registry #239

Merged
merged 9 commits into from
Dec 12, 2022
Merged

Create the IV registry #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cef6516
Add equilibrium solver registry and updates equilibrium_pdd
dalonsoa Nov 5, 2022
015097d
Skip running euilibrium or short circuit if not valid solver available
dalonsoa Nov 5, 2022
26bf68d
Remove metadata from notebooks
dalonsoa Nov 30, 2022
9362ea7
Improve docstring of ProcessStructure
dalonsoa Nov 30, 2022
06c99cf
Further reorganisation of PDD code
dalonsoa Nov 30, 2022
39f7d0b
Split long comments into multiple lines in the PDD module
dalonsoa Nov 30, 2022
36557fb
Add register_iv_solver decorator
dalonsoa Nov 30, 2022
8e57315
Add test_generic_register
dalonsoa Nov 30, 2022
03b64dc
Add tests for all the registries
dalonsoa Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/kynan/nbstripout
rev: master
rev: 0.6.1
hooks:
- id: nbstripout
files: ".ipynb"
2 changes: 1 addition & 1 deletion examples/advanced_examples/MJ_solar_cell_tutorial.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,4 +580,4 @@
},
"nbformat": 4,
"nbformat_minor": 2
}
}
28 changes: 13 additions & 15 deletions examples/advanced_examples/differential_evolution_4Jcell.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,11 @@
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"pycharm": {
"name": "#%%\n"
}
},
"outputs": [],
"source": [
"class calc_min_Jsc():\n",
Expand Down Expand Up @@ -326,28 +331,21 @@
" # assuming an AM1.5G spectrum\n",
" self.spectr = LightSource(source_type='standard', version='AM1.5g', x=self.wl,\n",
" output_units='photon_flux_per_nm', concentration=1).spectrum(self.wl)[1]"
],
"metadata": {
"collapsed": false,
"pycharm": {
"name": "#%%\n"
}
}
]
},
{
"cell_type": "code",
"execution_count": null,
"outputs": [],
"source": [
" bot_cell_n_material = Ge(Nd=si(\"2e18cm-3\"), hole_diffusion_length=Ge_L_h, hole_mobility=Ge_mobility_h)\n",
" bot_cell_p_material = Ge(Na=si(\"1e17cm-3\"), electron_diffusion_length=Ge_L_e, electron_mobility=Ge_mobility_e)"
],
"metadata": {
"collapsed": false,
"pycharm": {
"name": "#%%\n"
}
}
},
"outputs": [],
"source": [
" bot_cell_n_material = Ge(Nd=si(\"2e18cm-3\"), hole_diffusion_length=Ge_L_h, hole_mobility=Ge_mobility_h)\n",
" bot_cell_p_material = Ge(Na=si(\"1e17cm-3\"), electron_diffusion_length=Ge_L_e, electron_mobility=Ge_mobility_e)"
]
},
{
"cell_type": "code",
Expand Down Expand Up @@ -618,4 +616,4 @@
},
"nbformat": 4,
"nbformat_minor": 2
}
}