Refactor IV PDD code #240
Merged
Refactor IV PDD code #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #240 +/- ##
===========================================
+ Coverage 46.07% 47.28% +1.21%
===========================================
Files 85 85
Lines 9133 9320 +187
===========================================
+ Hits 4208 4407 +199
+ Misses 4925 4913 -12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
iv_pddfunction was a long and rather messy one. This PR breaks it down into smaller chunks that are easy to test and to understand, as well as adding thorough docstrings explaining what the function does.This should be reviewed and merger after #239 , so only the actual modifications done appear in the diff.