Bugfix in CreateCustom #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug in create custom where when no expiresAt is specified, the default expiresAt creation had two issues: * It used a go1.17 API time.UnixMicro, wihch breaks backward compatibility * The function was used wrongly as the 2nd param of time.Unix() As a result of this, we have to issue this fix to ensure that the 1.4 stream still works with old version of the Go language. And we also have to retract the v1.4.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in create custom where when no expiresAt is specified,
the default expiresAt creation had two issues:
It used a go1.17 API time.UnixMicro, wihch breaks backward
compatibility
The function was used wrongly as the 2nd param of time.Unix()
As a result of this, we have to issue this fix to ensure that the
1.4 stream still works with old version of the Go language. And we
also have to retract the v1.4.0 release.