fix(Fetch Do): fetch all the blocks in the manifest, do not diff #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
Missing()
uses the nodegetter methodGet
if you are online, this method attempts to the get the blocks off the network, not just attempting to get them locally. This takes a long time and makes
Missing()
unusable as of right now. Instead, we are passingNewCompletion
an empty diffManifest
. We will be asking the remote source for the entire list of blocks, and although in certain cases this may be redundant, it is ultimately faster until we can changeMissing