Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(websocket): add authentication to websocket connection #345

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

ramfox
Copy link
Member

@ramfox ramfox commented Sep 24, 2021

closes #316

depends on qri-io/qri#1921

@ramfox ramfox added the feat label Sep 24, 2021
@ramfox ramfox added this to In progress in Sprints via automation Sep 24, 2021
@ramfox ramfox moved this from In progress to Needs Review in Sprints Sep 24, 2021
@ramfox ramfox added this to the Up Next milestone Sep 24, 2021
@ramfox ramfox self-assigned this Sep 24, 2021
Sprints automation moved this from Needs Review to Reviewer approved Sep 24, 2021
src/features/websocket/middleware/websocket.ts Outdated Show resolved Hide resolved
src/features/websocket/middleware/websocket.ts Outdated Show resolved Hide resolved
If we are already logged in, or have just successfully logged in, we need to authenticate our connection. This will let the backend know that it should send the events associated with the current session's profileID over the websocket connection.

If we ever logout, we need to unsubscribe to this connection.
@ramfox ramfox merged commit 6726bc5 into master Sep 24, 2021
Sprints automation moved this from Reviewer approved to Done Sep 24, 2021
@ramfox ramfox deleted the ramfox/feat_websocket_auth branch September 24, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

User should only see toasts for their own runs
2 participants