feat(websocket): add process to authenticate websocket connections #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramfox
force-pushed
the
ramfox/feat_scoped_websocket
branch
from
972cf3b
to
37f1808
Compare
ramfox
commented
Sep 23, 2021
ramfox
force-pushed
the
ramfox/feat_scoped_websocket
branch
from
37f1808
to
a0dd49a
Compare
ramfox
commented
Sep 23, 2021
ramfox
commented
Sep 23, 2021
ramfox
commented
Sep 23, 2021
lib/websocket_test.go
Outdated
| connID := newID() | ||
| SetIDRand(strings.NewReader(randIDStr)) | ||
|
|
||
| wsh.WSConnectionHandler(mockWebsocketWriterAndRequest()) |
There was a problem hiding this comment.
this tests that the wsHandler is setting up a connection & placing it in the conns map.
However, it doesn't set us up to be able to test the wsHandler.read or wsHandler.handleMessage methods. May need to expand on the mockHijacker struct below & create methods that allow us to write on the connection.
b5
reviewed
Sep 24, 2021
ramfox
force-pushed
the
ramfox/feat_scoped_websocket
branch
from
a0dd49a
to
e7f976f
Compare
Websocket connections need to be scoped so we only send the relevant events to the correct connections. To accomplish this, we keep track of the profile.ID of each connections using the new `websocket.conn` struct, as well as keeping a map of profile.IDs to connections. To allow us to authenticate tokens, the `websocket.Handler` must have access to the `key.Store`. We've added an authentication handshake. Once the connection has been established, the client can request to "subscribe" to a connection, and send over a token as part of the message payload. If that token is valid, we upgrade the connection, and send over a success message. If not, we send over a failure message. If the client wants to unsubscribe, they send over an "unsubscribe" request. This will remove the association between that connection and a profile.ID. It will not close the connection. We've also defined a `websocket.message` struct that the websocket expects to receive for communication about the state of the websocket connection (namely the authentication handshake).
ramfox
force-pushed
the
ramfox/feat_scoped_websocket
branch
from
e7f976f
to
ef8110e
Compare
ramfox
changed the title
Subscribe & Unsubscribe process to websocket connections
ramfox
commented
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1912
also moves
websocketwork into its own package