Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test.toolchain field #172

Merged
merged 4 commits into from
Nov 6, 2021
Merged

Add test.toolchain field #172

merged 4 commits into from
Nov 6, 2021

Conversation

qryxip
Copy link
Owner

@qryxip qryxip commented Oct 17, 2021

Enables running cargo compete test with old Rust without Rustup Override.

Since rust-analyzer no longer works under Rust 1.42 environment, we have to explicity specify +1.42.0 for testing.

@lnicola
Copy link

lnicola commented Oct 17, 2021

Hello from rust-analyzer! We might still revert the change that prompted this, but this PR seems like a good idea anyway.

My suggestion here would be to set a different target directory (CARGO_TARGET_DIR) for cargo-compete. If you use the same one, rust-analyzer's check on save and cargo-compete will block each other and overwrite their build artifacts.

@qryxip qryxip marked this pull request as ready for review November 6, 2021 11:54
@qryxip qryxip enabled auto-merge November 6, 2021 11:55
@qryxip qryxip merged commit fcf9612 into master Nov 6, 2021
@qryxip qryxip deleted the add-test-toolchain-field branch November 6, 2021 12:07
@qryxip
Copy link
Owner Author

qryxip commented Nov 6, 2021

@lnicola Thank you for pointing it out. I will think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants