Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSLT: xsl:for-each-group/@break-when #571

Closed
michaelhkay opened this issue Jun 23, 2023 · 5 comments
Closed

XSLT: xsl:for-each-group/@break-when #571

michaelhkay opened this issue Jun 23, 2023 · 5 comments
Labels
Feature A change that introduces a new feature Requires confirmation Text is in the current draft but requires WG review and acceptance XSLT An issue related to XSLT

Comments

@michaelhkay
Copy link
Contributor

The new @break-when attribute on xsl:for-each-group

(a) has not been reviewed by the CG

(b) is not mentioned in the changes appendix

(c) is not included in the schema-for-XSLT40

@ndw
Copy link
Contributor

ndw commented Jun 23, 2023

That's a third potential XSLT item. I think it's probably time for another XSLT-focused meeting, ideally before the August break. I'll put that on the agenda for next week.

@michaelhkay michaelhkay added XSLT An issue related to XSLT Feature A change that introduces a new feature Revise PR has been discussed and substantive changes requested Requires confirmation Text is in the current draft but requires WG review and acceptance and removed Revise PR has been discussed and substantive changes requested labels Jul 4, 2023
@Arithmeticus
Copy link
Contributor

When I first saw this new construct (tonight in fact), I was under the impression, simply from the name, that this would provide a mechanism to terminate the for-each-group process, akin to xsl:break within xsl:iterate. If the floor is still open, might I recommend another name such as @start-new-group-when or @regroup-when or @close-current-group-when or @group-division-with or something like that? Something without "break" and its overtones?

BTW, this fifth option is greatly appreciated, and will save me some gymnastics and hacks.

@michaelhkay
Copy link
Contributor Author

Good point. Perhaps split-when?

@ndw
Copy link
Contributor

ndw commented Sep 26, 2023

Yes, split-when seems to capture the semantics more clearly than break-when.

@ndw
Copy link
Contributor

ndw commented Sep 26, 2023

The CG agreed to accept this as the status quo at meeting 047.

There's an action on MK to change the name of the attribute to split-when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A change that introduces a new feature Requires confirmation Text is in the current draft but requires WG review and acceptance XSLT An issue related to XSLT
Projects
None yet
Development

No branches or pull requests

3 participants