779 hash function #937
Merged
779 hash function #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arithmeticus
added
XQFO
ChristianGruen
requested changes
Jan 10, 2024
| hash functions with implementation-defined semantics.</p> | ||
| </fos:rules> | ||
| <fos:errors> | ||
| <p>A dynamic error is raised ([TODO: error code]) if the effective value of |
There was a problem hiding this comment.
FOCH0005 might be an appropriate error code (unfortunately, the XQFO error codes are quite cryptic).
|
Thanks, Christian, for the excellent suggestions and catches. Latest commit addresses them all, + a few more. To-do / desiderata would be examples using binary input. |
ChristianGruen
requested changes
Jan 15, 2024
|
I still do not understand why this would be put into fn and not into a separate hash module. Or it could fit into Expath's binary module md5 and sha-1 are already deprecated anyways |
|
The CG agreed to merge this PR at meeting 062 |
michaelhkay
added
Tests Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of hash function, proposed in #779.
Error message left as to-do item; guidance from editors appreciated.
I opted to leave out wrapper/cryptographic functionality, such as salting, and to demonstrate via example how it could be done by a developer on their own. In my opinion what we need here is a simple atomic function that can be incorporated into other molecular functions.
I may tinker with the prose description up to CG discussion, so comments are welcome.