Skip to content

Commit

Permalink
Change to run the static checker(mypy) with make.
Browse files Browse the repository at this point in the history
In the CI, the code is checked by the mypy, but ckpatch command in Makefile has no checking the test. I think it is forgot to add the test. This patch fixes the problem.
  • Loading branch information
sux2mfgj authored and flacjacket committed Aug 13, 2019
1 parent 7fe808b commit 18a4e15
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,12 @@ check-cov:
lint:
flake8 ./libqtile bin/q* ./test

.PHONY: static_check
static_check:
mypy -p libqtile

.PHONY: ckpatch
ckpatch: lint check
ckpatch: lint check static_check

.PHONY: clean
clean:
Expand Down
1 change: 1 addition & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ flake8
pep8-naming
psutil
pytest-cov
mypy

0 comments on commit 18a4e15

Please sign in to comment.