fix window iteration on config reload to only look at managed windows

qtile · Jan 27, 2024 · 5279450 · 5279450
1 parent b6dbc23
commit 5279450
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/libqtile/backend/wayland/core.py b/libqtile/backend/wayland/core.py
@@ -1203,10 +1203,10 @@ def on_config_load(self, initial: bool) -> None:
 
         assert self.qtile is not None
 
-        for win in self.qtile.windows_map.values():
-            if not isinstance(win, window.Window):
-                continue
-
+        managed_wins = [
+            w for w in self.qtile.windows_map.values() if isinstance(w, window.Window)
+        ]
+        for win in managed_wins:
             group = None
             if win.group:
                 if win.group.name in self.qtile.groups_map:

diff --git a/libqtile/backend/x11/core.py b/libqtile/backend/x11/core.py
@@ -241,9 +241,11 @@ def on_config_load(self, initial) -> None:
 
         if not initial:
             # We are just reloading config
-            for win in self.qtile.windows_map.values():
-                if type(win) is window.Window:
-                    win.set_group()
+            managed_wins = [
+                w for w in self.qtile.windows_map.values() if isinstance(w, window.Window)
+            ]
+            for managed_win in managed_wins:
+                managed_win.set_group()
             return
 
         # Qtile just started - scan for clients