Skip to content

Commit

Permalink
tests: reorder SIGWINCH to be after sleep
Browse files Browse the repository at this point in the history
It looks like in a recent run:
https://github.com/qtile/qtile/actions/runs/8321862376/job/22786549176
which had my previous patch we didn't get the stack traces. Presumably
that's because we sent SIGWINCH and then immediately sent SIGKILL. I meant
to put this sleep *after* SIGWINCH to give python time to walk its stack,
but put it before. derp.

Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
  • Loading branch information
tych0 committed Mar 18, 2024
1 parent c9ff6d8 commit 6f2c2ad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ def terminate(self):
if self.proc.is_alive():
# uh oh, we're hung somewhere. give it another second to print
# some stack traces
self.proc.join(1)
os.kill(self.proc.pid, signal.SIGWINCH)
self.proc.join(1)
print("Killing qtile forcefully", file=sys.stderr)
# desperate times... this probably messes with multiprocessing...
try:
Expand Down

0 comments on commit 6f2c2ad

Please sign in to comment.