New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification role window is not treated properly #4662
Comments
Can you post an xprop of the notification window. Please also confirm what the desired behaviour should be. |
xprop:
I expect that this notification will be sticky (remaining in top right corner when I switch groups) and to not steal focus when it opens. |
The way we handle notification windows is to make them floating but they shouldn't steal focus. That code was in place back in 0.21.0 too. When I create a notification window it doesn't steal focus so I'm not sure why this one is. Our code doesn't make the notification "sticky". |
Here is
|
Any other information I can provide? I'd really like to fix this somehow. |
The only place I can really tell that we treat them differently is below,
I don't know that we'd want to apply that patch (it may make e.g. gimp windows a bit wonky), but can you confirm whether that matches the behavior you expect? |
I was reluctant to change that too. The broader question seems to be whether we make notification windows static so they appear on every group. |
Yep, and IMO we don't. Stuff from libnotify is type notification, which means those will show up on every desktop. Perhaps an option to do so but off by default is the best we'd do. (But users can already do this right? they can hook |
I'm not sure if there is a standard for this, but are you saying that Firefox basically switched to incorrect (not appropriate) window type for their notification and they should fix it? I can workaround it on my end, but I am also interested in knowing what is the root cause here and where it should, ideally, be fixed. |
They definitely changed it. Whether it's incorrect is a matter of opinion. I believe they've made a correct decision here. If you read https://specifications.freedesktop.org/wm-spec/1.5/ar01s05.html#idm44882398096864 it says of "utility" (i.e. the old style):
and of notification
IMO, we only want notifications to be displayed on the current desktop, vs. all of them (although, is that the old behavior of utility windows? I don't think so right?). |
Should Firefox be setting the override-redirect attribute here? Would that solve the issue? |
Ok. I've tested this a bit:
So, it looks like firefox should set that flag (which would be in line with the spec that Tych0 posted above). |
Will it still capture focus in that case though? |
I don't think so. Once I've done those steps, clicking on the window does not focus the window. If you want to try it, this is the script I used: #!/usr/bin/bash
xprop -f _NET_WM_WINDOW_TYPE 32a -set _NET_WM_WINDOW_TYPE _NET_WM_WINDOW_TYPE_NOTIFICATION -id $1
xdotool set_window --overrideredirect 1 $1
xdotool windowunmap $1
xdotool windowmap $1 I run it with the ID of an existing window. |
…erts. r=stransky This prevents some WMs from stealing focus, see qtile/qtile#4662 Differential Revision: https://phabricator.services.mozilla.com/D202701
…erts. r=stransky This prevents some WMs from stealing focus, see qtile/qtile#4662 Differential Revision: https://phabricator.services.mozilla.com/D202701
Firefox Nightly (at least) landed a change (can be seen in links above) that changes redirect property, now it looks like this:
However all of the issues still remain unfortunately. I also tried patch from #4662 (comment) and it doesn't seem to make any difference. I'm really looking forward to solution here. Upgraded to 0.25.0 already. |
Actually #4662 (comment) breaks pop-up windows of various kinds, while they do still seem to steal focus, they are invisible behind other apps for some reason 👀 |
I was using |
Issue description
Firefox recently changes role of notifications from "utility" to "notification" and Qtile fails to treat it properly, more specifically notification window only shows up on the same group as Firefox itself and steals focus from currently active window.
My Qtile version is a bit old, so feel free to tell me if this was fixed already upstream.
Version
0.21.0
Backend
X11 (default)
Config
No response
Logs
No response
Required
The text was updated successfully, but these errors were encountered: